Skip to content

[Feature]: use a DSN for credentials #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task done
dkarlovi opened this issue Jan 5, 2024 · 0 comments · Fixed by #57
Closed
1 task done

[Feature]: use a DSN for credentials #50

dkarlovi opened this issue Jan 5, 2024 · 0 comments · Fixed by #57
Assignees

Comments

@dkarlovi
Copy link

dkarlovi commented Jan 5, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Describe the new feature

Currently, the credentials are passed individually, like so

unleash_symfony_client:
  app_url: http://localhost:4242/api
  instance_id: myCoolApp-Server1
  app_name: myCoolApp

A better approach would be to allow a single string to represent all three values, a so called DSN (at least that's a common name in Symfony ecosystem for this concept).

unleash_symfony_client:
  url: http://localhost:4242/api&instance_id=myCoolApp-Server1&app_name=myCoolApp

Why?

It makes this a single piece of data which is easier to manage as a secret (for example in k8s). This approach is very common otherwise, for example Symfony itself uses it for cache and messenger, Doctrine uses it for the DB connection string, etc.

Is your feature request related to a problem? (optional)

No response

Describe alternatives you've considered (optional)

You can store JSON in the secret and then unwrap it, but that's cumbersome to manage.

Additional context (optional)

In some cases, you're billed per secret used so keeping it all together reduces cost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants