Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support qBittorrent v5 #1928

Merged
merged 12 commits into from
Oct 6, 2024
Merged

feat: Support qBittorrent v5 #1928

merged 12 commits into from
Oct 6, 2024

Conversation

Larsluph
Copy link
Collaborator

@Larsluph Larsluph commented Sep 30, 2024

Now that qBittorrent v5 is officially released, we can start implementing new features. Let's start by fixing breaking changes.

Using git diff release-4.6.7...release-5.0.0 -- src\webui\api to generate changes in WebAPI.

  • Update types and deprecate old symbols
  • Fix breaking changes (start/stop)
  • Implement search plugin download
  • Display new search plugin result properties
  • Implement test email
  • Add new settings
  • Support getDirectoryContent, use it instead of local history if on qbit 5.0

@Larsluph Larsluph mentioned this pull request Oct 1, 2024
4 tasks
@Larsluph Larsluph marked this pull request as ready for review October 1, 2024 21:53
@Larsluph Larsluph requested a review from WDaan as a code owner October 1, 2024 21:53
@Larsluph
Copy link
Collaborator Author

Larsluph commented Oct 1, 2024

Build is now working with new types, v5 features will be implemented in another PR to prevent further reports from users.

@WDaan
Copy link
Collaborator

WDaan commented Oct 3, 2024

Is this PR breaking? It looks like it isn't but I'm afraid about V4 setups breaking.

@Larsluph
Copy link
Collaborator Author

Larsluph commented Oct 3, 2024

I tried keeping everything by only adding new stuff and deprecating others. I'm in the process of reviewing everything to make sure I did keep the old compatibility.

I was also thinking about making a baseline for qBittorrent 4 users that may be unable to update or that just don't want to. So that we can focus on qBit 5 without thinking about retro-compatibility.

@Larsluph
Copy link
Collaborator Author

Larsluph commented Oct 3, 2024

Everything has been double-checked, looks good.

Copy link
Collaborator

@WDaan WDaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay, looks fine 👌

Let's go v5 🚀

@Larsluph Larsluph merged commit 69e29d4 into master Oct 6, 2024
1 check passed
@Larsluph Larsluph deleted the feat/qbit-v5 branch October 6, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants