Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TorrentDetail): Add torrent navigation buttons #2108

Merged
merged 2 commits into from
Dec 31, 2024
Merged

Conversation

Larsluph
Copy link
Collaborator

@Larsluph Larsluph commented Dec 29, 2024

Fixes #2106

This PR adds 4 buttons to the Torrent Detail view. These buttons' actions are as follows from left to right:

  • go to first filtered torrent
  • go to previous filtered torrent
  • go to next filtered torrent
  • go to last filtered torrent

image

Also a new store has been introduced to allow for remounting the router component and ensure that lifecycle event are properly executed.

@Larsluph Larsluph self-assigned this Dec 29, 2024
@Larsluph Larsluph requested a review from WDaan as a code owner December 29, 2024 08:00
@Larsluph Larsluph merged commit 488958d into master Dec 31, 2024
1 check passed
@Larsluph Larsluph deleted the feat/router branch December 31, 2024 09:04
@Phil57
Copy link

Phil57 commented Dec 31, 2024

Hello, this works fine for for me it breaks the content tab. No matter the torrent I select, the content tab will always display content of the first torrent of the list.
Other tabs are fine.

@Larsluph
Copy link
Collaborator Author

I was just looking into that issue too. It looks likes dependency changes broke some stuff in the reactivity of the app, will run rollback and release patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Arrow buttons to switch between torrents in detail view
3 participants