Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the Chinese word order problem #765

Merged
merged 1 commit into from
Apr 25, 2023
Merged

fix: fix the Chinese word order problem #765

merged 1 commit into from
Apr 25, 2023

Conversation

Moius
Copy link
Contributor

@Moius Moius commented Apr 13, 2023

fix: fix the Chinese word order problem

Modified part of the problem that the display is correct in English but the word order is wrong in Chinese. Both Simplified Chinese and Traditional Chinese are supported, but this is a temporary fix. Because this problem may not exist after refactoring.

PR Checklist

  • I've started from master
  • I've only committed changes related to this PR
  • All Unit tests pass
  • I've removed all commented code
  • I've removed all unneeded console.log statements

@Moius
Copy link
Contributor Author

Moius commented Apr 13, 2023

I am not modifying the translation of traditional Chinese, I hope @VEWION can help to modify the translation of traditional Chinese for adaptation. THANKS!

@Moius
Copy link
Contributor Author

Moius commented Apr 14, 2023

@WDaan Hello! If this PR is not merged, then #766 should not be merged either. This PR fixes the displaying inflection problem between Simplified Chinese and Traditional Chinese by modifying the getters.ts file, and only modifies the translation of Simplified Chinese to match the inflection, #766 modifies the translation of Traditional Chinese to match the inflection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants