From 4656bcb1e93607fe5acb8151ce7bdeaa5a7106f8 Mon Sep 17 00:00:00 2001 From: emorozov Date: Mon, 11 Mar 2024 14:43:09 +0500 Subject: [PATCH] feat(Messages): Change message editing method to update() --- src/webexpythonsdk/api/messages.py | 7 +++++-- tests/api/test_messages.py | 8 ++++++-- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/src/webexpythonsdk/api/messages.py b/src/webexpythonsdk/api/messages.py index 051b183..60d8845 100644 --- a/src/webexpythonsdk/api/messages.py +++ b/src/webexpythonsdk/api/messages.py @@ -357,8 +357,8 @@ def delete(self, messageId): # API request self._session.delete(API_ENDPOINT + "/" + messageId) - def edit(self, messageId=None, roomId=None, text=None, markdown=None): - """Edit a message. + def update(self, messageId=None, roomId=None, text=None, markdown=None): + """Update (edit) a message. Args: messageId(str): The ID of the message to be edit. @@ -391,3 +391,6 @@ def edit(self, messageId=None, roomId=None, text=None, markdown=None): # Return a message object created from the response JSON data return self._object_factory(OBJECT_TYPE, json_data) + + # Add edit() as an alias to the update() method for backward compatibility + edit = update diff --git a/tests/api/test_messages.py b/tests/api/test_messages.py index 1c40feb..67d1043 100644 --- a/tests/api/test_messages.py +++ b/tests/api/test_messages.py @@ -364,16 +364,20 @@ def test_get_message_by_id(api, group_room_text_message): message = api.messages.get(group_room_text_message.id) assert is_valid_message(message) - def test_delete_message(api, group_room, send_group_room_message): text = create_string("Message") message = api.messages.create(group_room.id, text=text) assert is_valid_message(message) api.messages.delete(message.id) - def test_edit_message(api, group_room): text = create_string("Edit this Message") message = api.messages.create(group_room.id, text=text) text = create_string("Message Edited") assert text == api.messages.edit(message.id, group_room.id, text).text + +def test_update_message(api, group_room): + text = create_string("Update this Message") + message = api.messages.create(group_room.id, text=text) + text = create_string("Message Updated") + assert text == api.messages.edit(message.id, group_room.id, text).text