Fixed an issue where server settings weren't being applied in some cases.

niemyjski · niemyjski · commit 54c828a94a17 · 2015-06-01T11:07:58.000-05:00
diff --git a/src/submission/DefaultSubmissionClient.ts b/src/submission/DefaultSubmissionClient.ts
@@ -45,11 +45,11 @@ export class DefaultSubmissionClient implements ISubmissionClient {
         config.log.error(`Unable to parse settings: '${data}'`);
       }
 
-      if (!settings || !settings.settings || !settings.version) {
+      if (!settings || isNaN(settings.version)) {
         return callback(new SettingsResponse(false, null, -1, null, 'Invalid configuration settings.'));
       }
 
-      callback(new SettingsResponse(true, settings.settings, settings.version));
+      callback(new SettingsResponse(true, settings.settings || {}, settings.version));
     });
   }
 

Original file line number	Diff line number	Diff line change
`@@ -45,11 +45,11 @@ export class DefaultSubmissionClient implements ISubmissionClient {`
`45`	`45`	config.log.error(`Unable to parse settings: '${data}'`);
`46`	`46`	`}`
`47`	`47`
`48`		`- if (!settings \|\| !settings.settings \|\| !settings.version) {`
	`48`	`+ if (!settings \|\| isNaN(settings.version)) {`
`49`	`49`	`return callback(new SettingsResponse(false, null, -1, null, 'Invalid configuration settings.'));`
`50`	`50`	`}`
`51`	`51`
`52`		`- callback(new SettingsResponse(true, settings.settings, settings.version));`
	`52`	`+ callback(new SettingsResponse(true, settings.settings \|\| {}, settings.version));`
`53`	`53`	`});`
`54`	`54`	`}`
`55`	`55`