-
-
Notifications
You must be signed in to change notification settings - Fork 43
Description
Hi,
I am using this hook in one of my projects in conjunction with React 18 and Strict Mode. However, it appears that the hook does not report any values when used together with React Strict Mode.
See the following CodeSandbox for a demonstration of this issue.
This issue is caused by the fact that React Strict Mode renders components twice in development mode in order to detect problems. In particular, this behavior causes problems with the following logic (for tracking unmounts):
use-resize-observer/src/index.ts
Lines 196 to 200 in 653b0b9
useEffect(() => { | |
return () => { | |
didUnmount.current = true; | |
}; | |
}, []); |
Because the component is rendered twice, the component is marked as unmounted and no further size updates are reported by the hook.
I believe the following patch should resolve this issue:
const didUnmount = useRef(false);
useEffect(() => {
+ didUnmount.current = false;
return () => {
didUnmount.current = true;
};
}, []);