Remove unused function parse_salary

rohitpaulk · rohitpaulk · commit 616d08cdafa0 · 2015-02-05T15:43:41.000+05:30
diff --git a/app/models/opportunity.rb b/app/models/opportunity.rb
@@ -71,22 +71,6 @@ def self.human_attribute_name(attr,options={})
     HUMANIZED_ATTRIBUTES[attr.to_sym] || super
   end
 
-  def self.parse_salary(salary_string)
-    salary_string.match(/(\d+)\s*([kK]?)/)
-    number, thousands = Regexp.last_match[1], Regexp.last_match[2]
-
-    if number.nil?
-      0
-    else
-      salary = number.to_i
-      if thousands.downcase == 'k' || salary < 1000
-        salary * 1000
-      else
-        salary
-      end
-    end
-  end
-
   def self.based_on(tags)
     query_string = "tags:#{tags.join(' OR ')}"
     failover_scope = Opportunity.joins('inner join taggings on taggings.taggable_id = opportunities.id').joins('inner join tags on taggings.tag_id = tags.id').where("taggings.taggable_type = 'Opportunity' AND taggings.context = 'tags'").where('lower(tags.name) in (?)', tags.map(&:downcase)).group('opportunities.id').order('count(opportunities.id) desc')
diff --git a/spec/models/opportunity_spec.rb b/spec/models/opportunity_spec.rb
@@ -77,24 +77,6 @@
     end
   end
 
-  describe 'parse job salary' do
-    it 'should parse salaries correctly' do
-      # TODO: Refactor api calls to Sidekiq job
-			   VCR.use_cassette('Opportunity') do
-
-           salary = Opportunity.parse_salary('100000')
-           expect(salary).to eq(100_000)
-           salary = Opportunity.parse_salary('100')
-           expect(salary).to eq(100_000)
-           salary = Opportunity.parse_salary('100k')
-           expect(salary).to eq(100_000)
-           salary = Opportunity.parse_salary('100 K')
-           expect(salary).to eq(100_000)
-
-         end
-    end
-  end
-
   describe 'apply for job' do
     it 'should create a valid application' do
       # TODO: Refactor api calls to Sidekiq job
