From 2b0f52969c5e7791d2f9735ee68721fc9b59dd3e Mon Sep 17 00:00:00 2001 From: Alec Delaney <89490472+tekktrik@users.noreply.github.com> Date: Thu, 1 Sep 2022 20:16:31 -0400 Subject: [PATCH 1/5] Add .venv to .gitignore Signed-off-by: Alec Delaney <89490472+tekktrik@users.noreply.github.com> --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 544ec4a..db3d538 100644 --- a/.gitignore +++ b/.gitignore @@ -37,6 +37,7 @@ _build # Virtual environment-specific files .env +.venv # MacOS-specific files *.DS_Store From 15c6c2ed91258ac71a836f79e4a4018c161b089b Mon Sep 17 00:00:00 2001 From: Alec Delaney <89490472+tekktrik@users.noreply.github.com> Date: Thu, 19 Jan 2023 23:39:55 -0500 Subject: [PATCH 2/5] Add upload url to release action Signed-off-by: Alec Delaney <89490472+tekktrik@users.noreply.github.com> --- .github/workflows/release_gh.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/release_gh.yml b/.github/workflows/release_gh.yml index b8aa8d6..9acec60 100644 --- a/.github/workflows/release_gh.yml +++ b/.github/workflows/release_gh.yml @@ -16,3 +16,4 @@ jobs: uses: adafruit/workflows-circuitpython-libs/release-gh@main with: github-token: ${{ secrets.GITHUB_TOKEN }} + upload-url: ${{ github.event.release.upload_url }} From f48b94008d813597352d0b35c6648264c1df5c0d Mon Sep 17 00:00:00 2001 From: Tekktrik Date: Tue, 9 May 2023 20:26:25 -0400 Subject: [PATCH 3/5] Update pre-commit hooks Signed-off-by: Tekktrik --- .pre-commit-config.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 0e5fccc..70ade69 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -4,21 +4,21 @@ repos: - repo: https://github.com/python/black - rev: 22.3.0 + rev: 23.3.0 hooks: - id: black - repo: https://github.com/fsfe/reuse-tool - rev: v0.14.0 + rev: v1.1.2 hooks: - id: reuse - repo: https://github.com/pre-commit/pre-commit-hooks - rev: v4.2.0 + rev: v4.4.0 hooks: - id: check-yaml - id: end-of-file-fixer - id: trailing-whitespace - repo: https://github.com/pycqa/pylint - rev: v2.15.5 + rev: v2.17.4 hooks: - id: pylint name: pylint (library code) From 8cfb19bc2ee7627a98a725964e9822b014be8dec Mon Sep 17 00:00:00 2001 From: Tekktrik Date: Wed, 10 May 2023 22:23:28 -0400 Subject: [PATCH 4/5] Run pre-commit --- adafruit_as7341.py | 2 -- examples/as7341_flicker_detection.py | 1 - examples/as7341_simpletest.py | 1 - 3 files changed, 4 deletions(-) diff --git a/adafruit_as7341.py b/adafruit_as7341.py index 75800a4..9b61306 100644 --- a/adafruit_as7341.py +++ b/adafruit_as7341.py @@ -352,7 +352,6 @@ class AS7341: # pylint:disable=too-many-instance-attributes, no-member def __init__( self, i2c_bus: busio.I2C, address: int = _AS7341_I2CADDR_DEFAULT ) -> None: - self.i2c_device = i2c_device.I2CDevice(i2c_bus, address) if not self._device_id in [_AS7341_DEVICE_ID]: raise RuntimeError("Failed to find an AS7341 sensor - check your wiring!") @@ -454,7 +453,6 @@ def _wait_for_data(self, timeout: float = 1.0) -> None: sleep(0.001) def _write_register(self, addr: int, data: int) -> None: - self._buffer[0] = addr self._buffer[1] = data diff --git a/examples/as7341_flicker_detection.py b/examples/as7341_flicker_detection.py index 38cac7d..fa249a9 100644 --- a/examples/as7341_flicker_detection.py +++ b/examples/as7341_flicker_detection.py @@ -10,7 +10,6 @@ sensor.flicker_detection_enabled = True while True: - flicker_detected = sensor.flicker_detected if flicker_detected: print("Detected a %d Hz flicker" % flicker_detected) diff --git a/examples/as7341_simpletest.py b/examples/as7341_simpletest.py index 52f012d..b6fed31 100644 --- a/examples/as7341_simpletest.py +++ b/examples/as7341_simpletest.py @@ -15,7 +15,6 @@ def bar_graph(read_value): while True: - print("F1 - 415nm/Violet %s" % bar_graph(sensor.channel_415nm)) print("F2 - 445nm//Indigo %s" % bar_graph(sensor.channel_445nm)) print("F3 - 480nm//Blue %s" % bar_graph(sensor.channel_480nm)) From 28dc163512909c9ed21955c2b92b9444d6bba105 Mon Sep 17 00:00:00 2001 From: Tekktrik Date: Thu, 11 May 2023 08:27:21 -0400 Subject: [PATCH 5/5] Linted per pre-commit --- adafruit_as7341.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/adafruit_as7341.py b/adafruit_as7341.py index 9b61306..65e9535 100644 --- a/adafruit_as7341.py +++ b/adafruit_as7341.py @@ -510,7 +510,7 @@ def _configure_f5_f8(self) -> None: def flicker_detected(self) -> Optional[int]: """The flicker frequency detected in Hertz""" if not self._flicker_detection_1k_configured: - AttributeError( + raise AttributeError( "Flicker detection must be enabled to access `flicker_detected`" ) flicker_status = self._fd_status