on_disk argument for IconWidget to use OnDiskBitmap #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepler
suggested changes
Mar 17, 2021
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Mar 17, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_FRAM to 1.3.8 from 1.3.7: > Merge pull request adafruit/Adafruit_CircuitPython_FRAM#25 from caternuson/iss24 Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.8.1 from 3.8.0: > Merge pull request adafruit/Adafruit_CircuitPython_GPS#60 from lesamouraipourpre/length-data-type-check > Merge pull request adafruit/Adafruit_CircuitPython_GPS#61 from lesamouraipourpre/docs2 > Revert "[WILL BE REVERSED] Making change to test adabot release check" > [WILL BE REVERSED] Making change to test adabot release check Updating https://github.com/adafruit/Adafruit_CircuitPython_LC709203F to 2.0.3 from 2.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_LC709203F#10 from noahcoad/master Updating https://github.com/adafruit/Adafruit_CircuitPython_TCA9548A to 0.4.0 from 0.3.5: > Merge pull request adafruit/Adafruit_CircuitPython_TCA9548A#27 from caternuson/iss26_scan Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_Layout to 1.3.0 from 1.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_Layout#17 from FoamyGuy/iconwidget_ondisk Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 5.0.5 from 5.0.4: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#74 from KTibow/patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#72 from FoamyGuy/ignoreimport Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 0.2.3 from 0.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#14 from adafruit/jepler-rotary-example Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.4.1 from 1.4.0: > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#22 from makermelissa/main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds on
on_diskargument to the IconWidget constructor. If set toTrueit will use OnDiskBitmap instead of imageload which allows it to use less memory and seems to draw a bit quicker.I've defaulted it to
Falsebecause imageload allows for animating the icons, and I am not sure if that is possible with OnDiskBitmap. So user can choose which is more important to them for their specific device and project.I tested this using the most recent version of the touch_deck_code.py from here: https://github.com/FoamyGuy/Touch_Deck_Working_Files on a Feather RP2040