Skip to content

self._x and self._y are unused #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bablokb opened this issue Aug 19, 2022 · 3 comments
Closed

self._x and self._y are unused #55

bablokb opened this issue Aug 19, 2022 · 3 comments

Comments

@bablokb
Copy link

bablokb commented Aug 19, 2022

The parameters x and y to the constructor are saved to self._x and self._y, but these variables are never used. Do I miss something here?
(x and y themselves are passed to the super-class).
@makermelissa
Copy link
Collaborator

Are you referring to the sparkline? Yeah it might be able to be removed from there. Want to test that it still works after removing and submit a PR?

@bablokb
Copy link
Author

bablokb commented Aug 20, 2022

Yes, this is within the sparkline-constructor. I will remove those lines.

@bablokb bablokb mentioned this issue Aug 20, 2022
Merged
@tekktrik
Copy link
Member

Closed via #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@makermelissa @bablokb @tekktrik