Adding Support for Challenger 2040 WiFi boards. #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes for Challenger 2040 WIFI board
adding logic to set the initialzations for challenger board
Oops in 20, adding comment 19
More changes with some comments on what's working and not. AP scan not working for me with challenger yet...
For some reason the Adafruit code has TX and RX swapped for the default board assignments... Flipped back for challenger..
added support for challenger 2040 wifi
|
@mperino Hey, myself and a coworker wrote a guide on using black, which is the thing that is currently failing. Let me know if it helps! https://learn.adafruit.com/improve-your-code-with-pylint/black |
|
Black may actually fix the line too long error, but not necessarily, so if you can't figure out a way to fix it, feel free to ping me |
Edit lines to be under 88 for black.
|
@dherrada I fixed the long line manually. Do I need to create a new pull request, or is there a way to re-kick this one with the change. |
mperino
commented
Nov 17, 2021
|
@mperino Looks like you got it working. Good job! This whole CI thing is quite a steep learning curve. |
ladyada
approved these changes
Nov 17, 2021
|
not tested (and this library is not really supported) but lgtm :) thanks! |
|
So Much learning this week.. ALL a good thing.. Getting deeper into the weeds of Python, CircuitPython, and a bit of other stuff.. Hopefully I'll be contributing more |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 20, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP_ATcontrol to 0.6.0 from 0.5.9: > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#49 from mperino/main Updating https://github.com/adafruit/Adafruit_CircuitPython_CursorControl to 2.5.0 from 2.4.1: > Merge pull request adafruit/Adafruit_CircuitPython_CursorControl#28 from tekktrik/hotfix/remove-gamepad Updating https://github.com/adafruit/Adafruit_CircuitPython_datetime to 1.1.5 from 1.1.4: > Fixed requirements.txt Updating https://github.com/adafruit/Adafruit_CircuitPython_FunHouse to 2.1.6 from 2.1.5: > Merge pull request adafruit/Adafruit_CircuitPython_FunHouse#24 from tekktrik/feature/add-typing Updating https://github.com/adafruit/Adafruit_CircuitPython_Logging to 3.7.2 from 3.7.1: > Merge pull request adafruit/Adafruit_CircuitPython_Logging#24 from tekktrik/docfix/add-repo-version-info Updating https://github.com/adafruit/Adafruit_CircuitPython_RGBLED to 1.1.8 from 1.1.7: > Merge pull request adafruit/Adafruit_CircuitPython_RGBLED#18 from adafruit/patch-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_RTTTL to 2.4.8 from 2.4.7: > Merge pull request adafruit/Adafruit_CircuitPython_RTTTL#25 from tekktrik/feature/add-typing Updating https://github.com/adafruit/Adafruit_CircuitPython_SimpleMath to 2.0.2 from 2.0.1: > Fixed requirements file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current setup/init logic for this library is focused on the Particle Aragon. I added a If block to the examples with the default logic being the Particle (else) and (if board.board_id == "challenger_rp2040_wifi") being for the challenger. Should make it easier for adding other boards as well.
I moved the debug setting to a variable that is set in the early code.
For the Challenger boards I am getting some errors on AT commands not always sending back an expected OK. Have opened issue in Adafruit_CircuitPython_ESP_ATcontrol AT+CWLAP Does not return OK #48
I have also added a few comment lines that I think will help people. In aiocontrol_simpletest, I added a reminder that you need to create the feed in adafruitio, and what additional entries you need in the secrets file. In atcontrol_simpletest I added comments that the AP scan may fail and which lines to comment out if that is breaking (goes back to the opened issue).