Changed code to use sdcardio as preferred method #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhalbert
requested changes
Jun 15, 2022
There was a problem hiding this comment.
This seems good. I propose changing one already existing comment.
An alternate way of writing this is to try to import sdcardio, and if that fails, then you could decide at runtime what to do. But I think that has not been our style.
In general, only the smallest boards (M0 SAMD21) won't have sdcardio.
|
I should probably test this, but let me know if this looks good to you as far as formatting and documentation. Thanks! |
|
Looks good; I agree, it's a big enough change it's worth testing. |
dhalbert
approved these changes
Jun 16, 2022
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jun 18, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_DS1307 to 2.1.14 from 2.1.13: > Merge pull request adafruit/Adafruit_CircuitPython_DS1307#29 from tekktrik/main Updating https://github.com/adafruit/Adafruit_CircuitPython_GPS to 3.10.0 from 3.9.10: > Merge pull request adafruit/Adafruit_CircuitPython_GPS#80 from gamblor21/precision > Merge pull request adafruit/Adafruit_CircuitPython_GPS#81 from adafruit/sdcardio Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoTre to 1.1.11 from 1.1.10: > Merge pull request adafruit/Adafruit_CircuitPython_NeoTre#19 from caternuson/iss18 Updating https://github.com/adafruit/Adafruit_CircuitPython_Seesaw to 1.10.12 from 1.10.11: > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#104 from ladyada/main Updating https://github.com/adafruit/Adafruit_CircuitPython_VC0706 to 6.0.4 from 6.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_VC0706#31 from tekktrik/doc/add-motion-example > Merge pull request adafruit/Adafruit_CircuitPython_VC0706#30 from adafruit/sdcardio Updating https://github.com/adafruit/Adafruit_CircuitPython_Colorsys to 2.0.8 from 2.0.7: > Merge pull request adafruit/Adafruit_CircuitPython_Colorsys#21 from tekktrik/doc/add-missing-params Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.22.7 from 2.22.6: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#173 from tekktrik/doc/use-font-protocol Updating https://github.com/adafruit/Adafruit_CircuitPython_Logging to 4.1.0 from 4.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_Logging#31 from tekktrik/dev/publicize-handler-methods Updating https://github.com/adafruit/Adafruit_CircuitPython_NeoKey to 1.0.8 from 1.0.7: > Merge pull request adafruit/Adafruit_CircuitPython_NeoKey#8 from ladyada/main Updating https://github.com/adafruit/Adafruit_CircuitPython_PYOA to 2.5.6 from 2.5.5: > Merge pull request adafruit/Adafruit_CircuitPython_PYOA#33 from adafruit/sdcardio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.