Allow sending raw bytes in the response #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now only encode the body if it has an encode method, which usually means it's a string. This allows passing bytes, bytearray or memoryview. I also changed the logic for sending a chunk, that avoids copying the data unnecessarily. I believe this also fixes a bug, where the size of unencoded chunk was sent, in characters, instead of encoded size, in bytes.
dhalbert
approved these changes
Jan 11, 2023
|
@anecdata would you like to test, or shall I just merge? |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 12, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_IRRemote to 4.1.12 from 4.1.11: > trying 1.0.0 to make sure it'll get newer > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#59 from FoamyGuy/docs_theme_version > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#58 from FoamyGuy/docs_theme_version > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#57 from FoamyGuy/docs_theme_version > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#56 from FoamyGuy/docs_theme_version > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX1704x to 1.0.6 from 1.0.5: > Merge pull request adafruit/Adafruit_CircuitPython_MAX1704x#10 from adafruit/retry-reset-esp32s3 > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_HTTPServer to 2.1.0 from 2.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#35 from deshipu/main Updating https://github.com/adafruit/Adafruit_CircuitPython_LED_Animation to 2.6.2 from 2.6.1: > Merge pull request adafruit/Adafruit_CircuitPython_LED_Animation#107 from priestbh/main > Add .venv to .gitignore Updating https://github.com/adafruit/Adafruit_CircuitPython_Ticks to 1.0.9 from 1.0.8: > Merge pull request adafruit/Adafruit_CircuitPython_Ticks#9 from xgpt/patch-1 > Add .venv to .gitignore > Update .pylintrc for v2.15.5 > Fix release CI files > Update pylint to 2.15.5 > Updated pylint version to 2.13.0 > Switching to composite actions Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now only encode the body if it has an encode method, which usually means it's a string. This allows passing bytes, bytearray or memoryview.
I also changed the logic for sending a chunk, that avoids copying the data unnecessarily. I believe this also fixes a bug, where the size of unencoded chunk was sent, in characters, instead of encoded size, in bytes.
This fixes #33