-
Notifications
You must be signed in to change notification settings - Fork 25
Add MP3 playback and example with files. #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you! There are a few things that I wondered about.
@@ -0,0 +1,3 @@ | |||
# SPDX-FileCopyrightText: Copyright (c) 2021 Kattni Rembor for Adafruit Industries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be Copyright Bartlebeats instead? (presumably the same for all tracks)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering the same thing. Wasn't sure about who to add here. Good call.
int(255 / 12) * key_event.key_number | ||
) | ||
# If adding more MP3 files, add the appropriate key numbers to the tuple below. | ||
if key_event.key_number in (0, 1, 2, 3): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe if key_event.key_number < len(audio_files):
so that there's no need to keep things in synch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works! Updated!
@@ -0,0 +1,32 @@ | |||
# SPDX-FileCopyrightText: Copyright (c) 2021 Kattni Rembor for Adafruit Industries |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this file be examples/macropad_mp3/code.py? I am not sure about the new rules.
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For library code, Bundlefly automatically changes the file to code.py so that the files can continue to stay within library standards and Adabot remains happy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Updating https://github.com/adafruit/Adafruit_CircuitPython_MacroPad to 1.4.0 from 1.3.3: > Merge pull request adafruit/Adafruit_CircuitPython_MacroPad#25 from kattni/mp3-playback
No description provided.