Skip to content

Example should be renamed to include simpletest #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kattni opened this issue Sep 30, 2019 · 2 comments · Fixed by #33
Closed

Example should be renamed to include simpletest #31

kattni opened this issue Sep 30, 2019 · 2 comments · Fixed by #33
Labels
good first issue Hacktoberfest

Comments

@kattni
Copy link
Contributor

kattni commented Sep 30, 2019

Example motor_servo_sweep.py should be renamed to motor_servo_sweep_simpletest.py to fit with CircuitPython library standards.
@williamlai2 williamlai2 mentioned this issue Oct 1, 2019
Closed
@kattni
Copy link
Contributor Author

kattni commented Oct 1, 2019

Thanks for doing this! It's close! I've left comments on the PR.

@williamlai2 williamlai2 mentioned this issue Oct 2, 2019
Merged
@williamlai2
Copy link
Contributor

williamlai2 commented Oct 2, 2019 •
edited
Loading

I've redone it now. Hopefully this works better. I did the file rename in git. #33

@kattni kattni closed this as completed in #33 Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Renaming files
3 participants
@kattni @sommersoft @williamlai2