Add typing, minor fixes #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also addresses #24 |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 20, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP_ATcontrol to 0.6.0 from 0.5.9: > Merge pull request adafruit/Adafruit_CircuitPython_ESP_ATcontrol#49 from mperino/main Updating https://github.com/adafruit/Adafruit_CircuitPython_CursorControl to 2.5.0 from 2.4.1: > Merge pull request adafruit/Adafruit_CircuitPython_CursorControl#28 from tekktrik/hotfix/remove-gamepad Updating https://github.com/adafruit/Adafruit_CircuitPython_datetime to 1.1.5 from 1.1.4: > Fixed requirements.txt Updating https://github.com/adafruit/Adafruit_CircuitPython_FunHouse to 2.1.6 from 2.1.5: > Merge pull request adafruit/Adafruit_CircuitPython_FunHouse#24 from tekktrik/feature/add-typing Updating https://github.com/adafruit/Adafruit_CircuitPython_Logging to 3.7.2 from 3.7.1: > Merge pull request adafruit/Adafruit_CircuitPython_Logging#24 from tekktrik/docfix/add-repo-version-info Updating https://github.com/adafruit/Adafruit_CircuitPython_RGBLED to 1.1.8 from 1.1.7: > Merge pull request adafruit/Adafruit_CircuitPython_RGBLED#18 from adafruit/patch-fix Updating https://github.com/adafruit/Adafruit_CircuitPython_RTTTL to 2.4.8 from 2.4.7: > Merge pull request adafruit/Adafruit_CircuitPython_RTTTL#25 from tekktrik/feature/add-typing Updating https://github.com/adafruit/Adafruit_CircuitPython_SimpleMath to 2.0.2 from 2.0.1: > Fixed requirements file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things:
parse_note()now casts its argument tostrwhich I believe was the intention, and is my understanding of the correct implementation reading the code. Would definitely appreciate a second set of eyes on that.pwmioandaudioioto mock imports because Sphinx failed building otherwise