Check for send to return 0 #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When it does, close the socket and raise an Exception. This prevents leaking sockets when send fails.
brentru
approved these changes
Sep 24, 2020
There was a problem hiding this comment.
@tannewt LGTM, tested OK on all CPython examples.
Only thing that I noticed is the code catches an exception raised by _send and closes the socket within _send_request. Any function relying on _send will need to implement this try/except or the socket won't be closed.
Could you instead close the socket within _send when sent returns 0?
|
Thanks @brentru. I didn't put it there because I want to remove _send eventually when the send implementation of our sockets is consistent. I believe ESP32SPI's send works like CPython's |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Sep 25, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_FONA to 2.1.0 from 2.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_FONA#7 from brentru/update-property-docstrings Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.7.2 from 1.7.1: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#36 from tannewt/check_send
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When it does, close the socket and raise an Exception. This
prevents leaking sockets when send fails.