Skip to content

Fixed the Expected 01 but got 00 error #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 29, 2020

Conversation

makermelissa
Copy link
Collaborator

This fixes the Expected 01 but got 00 issue and increases the reliability of the library.

@makermelissa makermelissa requested a review from a team October 29, 2020 18:27
Copy link
Member

@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didnt test, looks good

@makermelissa makermelissa merged commit a2ec2a9 into adafruit:master Oct 29, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Oct 30, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 5.2.1 from 5.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#57 from markus-k/patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.5.2 from 3.5.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#112 from tannewt/return_earlier
  > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#111 from adafruit/rssi_fix

Updating https://github.com/adafruit/Adafruit_CircuitPython_IL0373 to 1.3.1 from 1.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_IL0373#12 from tannewt/grayscale

Updating https://github.com/adafruit/Adafruit_CircuitPython_MAX31865 to 2.2.5 from 2.2.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_MAX31865#23 from ben-lewis/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_TLV493D to 1.2.0 from 1.1.4:
  > Merge pull request adafruit/Adafruit_CircuitPython_TLV493D#7 from markus-k/reg-addr

Updating https://github.com/adafruit/Adafruit_CircuitPython_ProgressBar to 1.3.4 from 1.3.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_ProgressBar#18 from mtowara/mtowara-patch-1

Updating https://github.com/adafruit/Adafruit_CircuitPython_Register to 1.9.1 from 1.9.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Register#40 from AdamCummick/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.7.3 from 1.7.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_Requests#43 from makermelissa/master
@tannewt
Copy link
Member

tannewt commented Nov 3, 2020

This doesn't work with other socket implementations because CPython sockets don't return a boolean: https://docs.python.org/3/library/socket.html#socket.socket.connect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants