remove unnecessary wait_for_frame call for CP5.0 compatibility #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Which versions of CP did you test with? |
|
CP5.0 alpha and a build from prior to merge of the displayio changes. |
tannewt
requested changes
Sep 3, 2019
|
@tannewt correct - it was not needed in 4.x -- simply remove call to wait_for_frame |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Sep 6, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_CursorControl to 2.1.3 from 2.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_CursorControl#12 from brentru/fix-pybadge Updating https://github.com/adafruit/Adafruit_CircuitPython_Slideshow to 1.0.5 from 1.0.4: > Merge pull request adafruit/Adafruit_CircuitPython_Slideshow#14 from jerryneedell/jerryn_refresh Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_IL0373, Adafruit_CircuitPython_IL0398, Adafruit_CircuitPython_IL91874, Adafruit_CircuitPython_SSD1608, Adafruit_CircuitPython_SSD1675
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
displayio no longer supports "wait_for_frame()" uses display.auto_refresh which is enabled by default.
use try/except for backward compatibility.
tested on feather_m4_express with TFT featherwing and on PyPortal