Eliminate race condition to improve coordinate accuracy and reliability. #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Significantly improves touch coordinate accuracy and reliability.
FoamyGuy
approved these changes
Dec 30, 2021
There was a problem hiding this comment.
Looks good to me. Tested on PyPortal with Display_Button and simpletest from this library. Thanks for the improvement @CedarGroveStudios
|
@FoamyGuy Here's a calibration helper for built-in displays that works graphically or REPL-only. It provides a calibration tuple compatible with the screen rotation parameter. Next version will accommodate add-on displays. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 31, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.5.14 from 3.5.13: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#148 from tekktrik/doc/status-led-connect Updating https://github.com/adafruit/Adafruit_CircuitPython_Touchscreen to 1.1.8 from 1.1.7: > Merge pull request adafruit/Adafruit_CircuitPython_Touchscreen#18 from CedarGroveStudios/main > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE_Adafruit to 1.3.2 from 1.3.1: > Merge pull request adafruit/Adafruit_CircuitPython_BLE_Adafruit#15 from dhalbert/ulab-numpy > update rtd py version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was experiencing occasional touch coordinate errors, particularly when rapidly pressing the touchscreen. The existing code measured the x and y coordinates then would check to see if the z (pressed) value exceeded the touch threshold value. In some cases, the x and/or y coordinate value would reflect a measurement made before or while the screen was being pressed, resulting in a significant coordinate offset error even when averaged.
The modification changes the logic; the x and y values are not measured until after the z value exceeds the threshold, assuring coordinate accuracy and stability.
Tests without the changes experienced approximately 2 errors per 50 presses. The error rate dropped to 0 with the updated code. Tests were performed using CircuitPython 7.0.0 on a PyPortal Titano using DisplayIO Buttons and VectorIO objects.