Skip to content

Fix incorrect RGBW NeoPixel output #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2022
Merged

Fix incorrect RGBW NeoPixel output #102

merged 1 commit into from
Jun 11, 2022

Conversation

caternuson
Copy link
Contributor

Simple fix for #101.

This works:

Adafruit CircuitPython 7.2.5 on 2022-04-06; Adafruit Feather M4 Express with samd51j19
>>> import board
>>> from adafruit_seesaw import seesaw, neopixel
>>> ss = seesaw.Seesaw(board.I2C())
>>> pixels = neopixel.NeoPixel(ss, 20, 12, pixel_order=neopixel.GRBW)
>>> pixels.fill(0xFF0000)
>>>

This also works (assumes RGBW pixel order):

Adafruit CircuitPython 7.2.5 on 2022-04-06; Adafruit Feather M4 Express with samd51j19
>>> import board
>>> from adafruit_seesaw import seesaw, neopixel
>>> ss = seesaw.Seesaw(board.I2C())
>>> pixels = neopixel.NeoPixel(ss, 20, 12, bpp=4)
>>> pixels.fill(0xFF0000)
>>>

Trying to over specify incompatible values throws exception:

Adafruit CircuitPython 7.2.5 on 2022-04-06; Adafruit Feather M4 Express with samd51j19
>>> import board
>>> from adafruit_seesaw import seesaw, neopixel
>>> ss = seesaw.Seesaw(board.I2C())
>>> pixels = neopixel.NeoPixel(ss, 20, 12, bpp=3, pixel_order=neopixel.GRBW)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/lib/adafruit_seesaw/neopixel.py", line 78, in __init__
ValueError: Pixel order and bpp value do not agree.
>>>

@caternuson caternuson requested a review from a team June 8, 2022 00:17
tekktrik
tekktrik approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elegant fix!

@tekktrik tekktrik merged commit 1230da9 into adafruit:main Jun 11, 2022
@ladyada
Copy link
Member

ladyada commented Jun 11, 2022

thanks @caternuson i didnt get to look till now!

adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jun 11, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@4d873a0)
8ff94ab 
Updating https://github.com/adafruit/Adafruit_CircuitPython_Seesaw to 1.10.11 from 1.10.10:
  > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#102 from caternuson/iss101_bpp

Updating https://github.com/adafruit/Adafruit_CircuitPython_OneWire to 2.0.0 from 1.2.11:
  > Merge pull request adafruit/Adafruit_CircuitPython_OneWire#26 from dhalbert/use-onewireio
@ahodsdon ahodsdon mentioned this pull request Jun 12, 2022
Closed
This was referenced Jun 15, 2022
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tekktrik tekktrik tekktrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caternuson @ladyada @tekktrik