Skip to content

Commit 0f94088

Browse files
committed
fixes for ledc, servo lib is broken and external so we cantfix/wontfix
1 parent e1ace0a commit 0f94088

File tree

6 files changed

+12
-26
lines changed

6 files changed

+12
-26
lines changed

examples/adafruitio_09_analog_out/adafruitio_09_analog_out.ino

+2-9
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,7 @@ void setup() {
3131
// set up led pin as an analog output
3232
#if defined(ARDUINO_ARCH_ESP32)
3333
// ESP32 pinMode()
34-
ledcAttachPin(LED_PIN, 1);
35-
ledcSetup(1, 1200, 8);
34+
ledcAttachPin(LED_PIN,analogGetChannel(LED_PIN));
3635
#else
3736
pinMode(LED_PIN, OUTPUT);
3837
#endif
@@ -87,12 +86,6 @@ void handleMessage(AdafruitIO_Data *data) {
8786
Serial.print("received <- ");
8887
Serial.println(reading);
8988

90-
9189
// write the current 'reading' to the led
92-
#if defined(ARDUINO_ARCH_ESP32)
93-
ledcWrite(1, reading); // ESP32 analogWrite()
94-
#else
95-
analogWrite(LED_PIN, reading);
96-
#endif
97-
90+
analogWrite(LED_PIN, reading);
9891
}

examples/adafruitio_13_rgb/adafruitio_13_rgb.ino

+6-17
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,9 @@ void setup() {
4040

4141
#if defined(ARDUINO_ARCH_ESP32) // ESP32 pinMode
4242
// assign rgb pins to channels
43-
ledcAttachPin(RED_PIN, 1);
44-
ledcAttachPin(GREEN_PIN, 2);
45-
ledcAttachPin(BLUE_PIN, 3);
46-
// init. channels
47-
ledcSetup(1, 12000, 8);
48-
ledcSetup(2, 12000, 8);
49-
ledcSetup(3, 12000, 8);
43+
ledcAttachPin(RED_PIN,analogGetChannel(RED_PIN));
44+
ledcAttachPin(GREEN_PIN,analogGetChannel(GREEN_PIN));
45+
ledcAttachPin(BLUE_PIN,analogGetChannel(BLUE_PIN));
5046
#else
5147
pinMode(RED_PIN, OUTPUT);
5248
pinMode(GREEN_PIN, OUTPUT);
@@ -108,14 +104,7 @@ void handleMessage(AdafruitIO_Data *data) {
108104
Serial.println(data->value());
109105

110106
// invert RGB values for common anode LEDs
111-
#if defined(ARDUINO_ARCH_ESP32) // ESP32 analogWrite
112-
ledcWrite(1, 255 - data->toRed());
113-
ledcWrite(2, 255 - data->toGreen());
114-
ledcWrite(3, 255 - data->toBlue());
115-
#else
116-
analogWrite(RED_PIN, 255 - data->toRed());
117-
analogWrite(GREEN_PIN, 255 - data->toGreen());
118-
analogWrite(BLUE_PIN, 255 - data->toBlue());
119-
#endif
120-
107+
analogWrite(RED_PIN, 255 - data->toRed());
108+
analogWrite(GREEN_PIN, 255 - data->toGreen());
109+
analogWrite(BLUE_PIN, 255 - data->toBlue());
121110
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+

0 commit comments

Comments
 (0)