Skip to content

Crashes since #10260 #10274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dhalbert opened this issue Apr 21, 2025 · 1 comment · Fixed by #10275
Closed

Crashes since #10260 #10274

dhalbert opened this issue Apr 21, 2025 · 1 comment · Fixed by #10275
Labels
crash
Milestone
10.0.0

Comments

@dhalbert
Copy link
Collaborator

55b0f15, part of #10260, is causing crashes, as evidenced by #10271 (comment). I am only testing with @anecdata's test program in #10271 on a Pico W.
@dhalbert dhalbert added the crash label Apr 21, 2025
@dhalbert dhalbert added this to the 10.0.0 milestone Apr 21, 2025
@dhalbert dhalbert changed the title Crashes since #10271 Crashes since #10260 Apr 21, 2025
@dhalbert
Copy link
Collaborator Author

dhalbert commented Apr 21, 2025 •
edited
Loading

I fixed this by removing the NORETURN from NORETURN mp_obj_t MP_WEAK rtc_get_time_source_time(void) in shared-bindings/time/__init__.c. Since this is an MP_WEAK function, sometimes it's NORETURN, and sometimes it's not, and declaring it NORETURN here appears to be messing up the other cases.

There is another example of NORETURN on an MP_WEAK function, which I'll remove. Also #10260 doesn't consistently declare/define functions as NORETURN in both the .h and .c files, and that should be made consistent. EDIT: not necessarily needed.

@dhalbert dhalbert mentioned this issue Apr 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crash
Projects
None yet
Milestone
10.0.0
Development

Successfully merging a pull request may close this issue.

Don't NORETURN MP_WEAK functions dhalbert/circuitpython
1 participant
@dhalbert