Skip to content

Separate TLS implementation into ssl.SSLSocket #3994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
hierophect opened this issue Jan 14, 2021 · 3 comments
Closed

Separate TLS implementation into ssl.SSLSocket #3994

hierophect opened this issue Jan 14, 2021 · 3 comments
Labels
espressif applies to multiple Espressif chips network

Comments

@hierophect
Copy link
Collaborator

Currently, the Socketpool/Socket API somewhat awkwardly crams two different libraries into the same implementation, using LWIP for non-encrypted TCP and datagrams, and the IDF/mbed TLS library for encrypted communication. Since TLS isn't really a transport layer library, it would be better to separate it into a different implementation of Socket, so the current Socket code doesn't need to infer what kind of socket it's dealing with for each call.

This is a follow up issue to PR #3854.
@hierophect hierophect added espressif applies to multiple Espressif chips network labels Jan 14, 2021
@hierophect
Copy link
Collaborator Author

@tannewt this would be implemented all the way through shared-bindings, correct? So we'd have a new Socket.c file under ssl recreating the functions that can use TLS?

@tannewt
Copy link
Member

tannewt commented Jan 14, 2021

Yes. It should be SSLSocket to match CPython: https://docs.python.org/3/library/ssl.html?highlight=ssl#ssl.SSLSocket

@hierophect
Copy link
Collaborator Author

Resolved by #4049

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
espressif applies to multiple Espressif chips network
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tannewt @hierophect