Skip to content

All bundle libraries should have an examples folder #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mrmcwethy opened this issue Dec 20, 2017 · 13 comments
Closed

All bundle libraries should have an examples folder #493

mrmcwethy opened this issue Dec 20, 2017 · 13 comments
Assignees
@Sigafoos @mrmcwethy
Labels
documentation good first issue
Milestone
3.0

Comments

@mrmcwethy
Copy link

mrmcwethy commented Dec 20, 2017 •
edited
Loading

Here is the list of libraries that still need an examples folder:

Pending PRs needing Review

Completed PRs
@mrmcwethy mrmcwethy mentioned this issue Dec 21, 2017
Merged
@mrmcwethy mrmcwethy changed the title All bundle library should have an examples folder All bundle libraries should have an examples folder Jan 3, 2018
@mrmcwethy mrmcwethy mentioned this issue Jan 3, 2018
Merged
@Sigafoos
Copy link

Sigafoos commented Jan 4, 2018

I'm not seeing examples for some of the repos that you have checked off: Adafruit_CircuitPython_SD for example.

@mrmcwethy
Copy link
Author

@Sigafoos The checked ones are ones that I plan on adding examples to. If you want to help with examples, pick one that is not check yet.

@Sigafoos
Copy link

Sigafoos commented Jan 4, 2018

@mrmcwethy got it!

@mrmcwethy
Copy link
Author

@Sigafoos BTW: if you really like any of the ones I selected, please let me know, you can do em.

Sigafoos added a commit to Sigafoos/Adafruit_CircuitPython_Thermistor that referenced this issue Jan 4, 2018
@Sigafoos
Adding an example (adafruit/circuitpython#493)
7d007b9
mrmcwethy added a commit to adafruit/Adafruit_CircuitPython_Thermistor that referenced this issue Jan 4, 2018
@mrmcwethy
Merge pull request #2 from Sigafoos/examples
3d4c908 
Adding an example (adafruit/circuitpython#493)
#2 adafruit/circuitpython#493

Thanks, tried it out and work great.
@mrmcwethy mrmcwethy mentioned this issue Jan 5, 2018
Merged
Sigafoos added a commit to Sigafoos/Adafruit_CircuitPython_HID that referenced this issue Jan 6, 2018
@Sigafoos
Added examples for keyboard shortcuts and a mouse scrollwheel (adafru…
75f14ef 
…it/circuitpython#493)
@Sigafoos
Copy link

Sigafoos commented Jan 6, 2018

I believe SimpleIO can be closed after adafruit/Adafruit_CircuitPython_SimpleIO@6667bb6

@mrmcwethy
Copy link
Author

Ok, I moved SimpleIO to the Completed PR list.

This was referenced Jan 6, 2018
Merged
Merged
@mrmcwethy
Copy link
Author

https://github.com/adafruit/Adafruit_CircuitPython_MAX7219
https://github.com/adafruit/Adafruit_CircuitPython_BusDevice
https://github.com/adafruit/Adafruit_CircuitPython_HID

Ready for review.

This was referenced Jan 12, 2018
Merged
Merged
@mrmcwethy
Copy link
Author

@tannewt to get examples done for the current library, i had to lint it as well. These are examples that will need to be rewritten for you experimental version of IS31FL3731. Let me know if you want me to finish that work.

@tannewt
Copy link
Member

tannewt commented Jan 16, 2018

@mrmcwethy I'll merge it now.

I'm actually tempted to punt on the experimental version for a bit longer until we know how we want all of the displays to work.

@tannewt tannewt added this to the 3.0 milestone Jan 16, 2018
This was referenced Jan 18, 2018
Merged
Merged
Merged
Merged
@mrmcwethy mrmcwethy mentioned this issue Feb 8, 2018
Merged
This was referenced Feb 8, 2018
Merged
Merged
@mrmcwethy
Copy link
Author

We finally have examples folders for all the Adafruit Bundle Libraries. Thanks everyone!

@ladyada
Copy link
Member

ladyada commented Feb 9, 2018

AMAZING!!!! thanks x 1000 for your help @mrmcwethy

@tannewt
Copy link
Member

tannewt commented Feb 9, 2018

🎉

@dhalbert
Copy link
Collaborator

dhalbert commented Feb 9, 2018

@mrmcwethy thank you and thank everyone who else who contributed examples! The libraries are in great shape!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sigafoos Sigafoos

@mrmcwethy mrmcwethy

Labels
documentation good first issue
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
5 participants
@tannewt @Sigafoos @ladyada @dhalbert @mrmcwethy