Skip to content

Remove unneeded kwarg handler in setters #9863

Closed
@jepler

Description

@jepler

Based on text search, the following getters in audiofilters & audiodelays modules can have their kwarg handling removed. Each instance may save ~80 bytes of code/flash space:

shared-bindings/audiodelays/Echo.c:static mp_obj_t audiodelays_echo_obj_set_delay_ms
shared-bindings/audiodelays/Echo.c:static mp_obj_t audiodelays_echo_obj_set_decay
shared-bindings/audiodelays/Echo.c:static mp_obj_t audiodelays_echo_obj_set_mix
shared-bindings/audiodelays/Echo.c:static mp_obj_t audiodelays_echo_obj_set_freq_shift
shared-bindings/audiofilters/Filter.c:static mp_obj_t audiofilters_filter_obj_set_filter
shared-bindings/audiofilters/Filter.c:static mp_obj_t audiofilters_filter_obj_set_mix

ping @relic-se for interest (I don't seem to be able to assign you directly on the issue)

Please feel free to handle this as 1 or 2 PRs as you prefer.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions