Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a variation of a standard digital delay (no frequency shifting) which allows for multiple "tap" positions to draw from the delay buffer. Rhythmic delay effects can be achieved by using irregular tap positions, ie: dotted quarter notes.
Notes:
taps
parameter flexible, but any suggestions are welcome.synthio.BlockInput
is not supported at this time. I don't see any immediate benefits from adding in that feature.audiodelays.Echo
effect instead of its own, but doing so might add too much complexity.Currently,taps=None
results in silent output. An alternative would be to have it act as a standard delay in this circumstance...._get_buffer(...)
slightly to reduce complexity and flash usage. There are some performance drawbacks when not playing a sample through this effect directly, but that scenario is uncommon and the performance hit should be minimal. Another benefit is that trailing delays after a sample has ended should act properly.