Skip to content

Always set current working dir #10291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 28, 2025
Merged

Always set current working dir #10291

merged 2 commits into from
Apr 28, 2025

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Apr 24, 2025

PR #10263 moved it to only before code.py. This breaks the repl (and likely boot.py.)

Fixes #10289

@tannewt
Always set current working dir
8a28033 
PR micropython#10263 moved it to only before code.py. This breaks the repl (and
likely boot.py.)

Fixes micropython#10289
@tannewt
Copy link
Member Author

tannewt commented Apr 24, 2025

@relic-se please test. I just did a smoke test with Thonny.

@relic-se
Copy link

It fixes the problem for me! Thank you for resolving the issue. :)

@relic-se
Copy link

relic-se commented Apr 25, 2025 •
edited
Loading

Do you know what's going on with the '.dram0.bss' will not fit in region 'dram0_0_seg' on ESP32 S2? I've seen it come up for other recent PRs, but it doesn't seem like this PR would have any effect on flash storage or ram usage.

@eightycc
Copy link
Collaborator

Do you know what's going on with the '.dram0.bss' will not fit in region 'dram0_0_seg' on ESP32 S2? I've seen it come up for other recent PRs, but it doesn't seem like this PR would have any effect on flash storage or ram usage.

It's an issue where the size of iram resident routines (routines that cannot be run from flash) plus CP static RAM allocations overflow the DRAM 0 area. It is resolved for ESP32-S2 parts in this commit: 22519d8 by moving some FreeRTOS routines from iram to flash. It is part of the ESP-IDF 5.4.1 upgrade.

@relic-se
Copy link

@eightycc Thank you for the clarification!

@tannewt tannewt mentioned this pull request Apr 28, 2025
Closed
@tannewt tannewt requested a review from dhalbert April 28, 2025 16:59
dhalbert
dhalbert approved these changes Apr 28, 2025
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dhalbert dhalbert merged commit a1e2b0b into adafruit:main Apr 28, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Directory Listing in Thonny on latest 10.x
4 participants
@tannewt @relic-se @eightycc @dhalbert