Create zh.po #1741
Closed
Create zh.po #1741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
reviewed
Apr 4, 2019
too many characters needed in bdf font
|
I'm not sure where you want "zh_Latn_pinyin", do you mean the file should be called "zh_Latn_pinyin.po"? I think it is ready to merg. |
|
@hexthat yup I meant the filename. Both versions were ok to have although I know the simplified chinese won't work with the displayio terminal due to the font size. |
|
Did you find a font that works for pinyin as well? I think I'll need to add a way to change the font for a language but it shouldn't be too hard. |
|
This is current version of font I'm using, it replaces the default font. Not sure why it is smaller size. Is it missing something? |
|
@hexthat Nice! Can you include the updated font in a new directory under tools and hook it in? That should fix the build. Thanks! |
|
Closing in favor of #1788 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chinese-Hanyu Pinyin