Doc updates for 4.0.0 #1805
Merged
Doc updates for 4.0.0 #1805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tannewt
commented
Apr 16, 2019
- Fixes PDF generation on RTD
- Adds links to circuitpython.org for boards instead a big list.
- Adds branding guidelines
* Fixes PDF generation on RTD * Adds links to circuitpython.org for boards * Adds branding guidelines
|
The new README is viewable here: https://github.com/tannewt/circuitpython/blob/bebf32ad6fa894ad45895fd1595ba10d8437e486/README.rst |
dhalbert
requested changes
Apr 17, 2019
ptorrone
requested changes
Apr 17, 2019
|
Updated! New README now here: https://github.com/adafruit/circuitpython/blob/8b60b20f885a4f76109e25d01d6d178a99a3d850/README.rst |
dhalbert
requested changes
Apr 17, 2019
There was a problem hiding this comment.
Thanks for the changes. Just a few more things I should have noticed the first time.
Travis is failing with:
Building docs
0.63s$ (! var_search "${TRAVIS_TESTS-}" docs || sphinx-build -E -W -b html . _build/html) ; S=$? ; echo $S > status ; (exit $S)
Running Sphinx v1.8.5
Extension error:
Could not import extension sphinxcontrib.rsvgconverter (exception: No module named rsvgconverter)
The command "(! var_search "${TRAVIS_TESTS-}" docs || sphinx-build -E -W -b html . _build/html) ; S=$? ; echo $S > status ; (exit $S)" exited with 2.
0.06s
failed with status 2
ptorrone
previously approved these changes
Apr 17, 2019
dhalbert
approved these changes
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.