Skip to content

bleio: add central and scanner functionality, cleanup bleio API, some code restructure #1993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 30 commits into from
Jul 18, 2019
Merged

bleio: add central and scanner functionality, cleanup bleio API, some code restructure #1993

merged 30 commits into from
Jul 18, 2019

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Jul 11, 2019 •
edited
Loading

  • Add BLE central functionality to Service, Characteristic, and CharacteristicBuffer. Add new native classes Central and Scanner.
  • Deleted remnants of Device code (was combined central and peripheral).
  • Remove AddressType. Now it's just an integer. Address changed correspondingly.
  • Deleted AdvertisementData. BLE Advertisement data is now constructed in Python, in adafruit_ble.advertising.
  • Broadcaster removed as a separate class for beacons to avoid a lot of duplicated code. Now handled by Peripheral.
  • Stopped using bleio object struct fields directly in shared-bindings/. Use common-hal operations instead.
  • Updated copyrights in many places.
  • Moved some bleio object structs out of shared-module into ports/nrf/common-hal, as they were not necessarily port-independent.
  • Renamed static list_clear() in py/objlist.c to public mp_obj_list_clear(), because I had a use for it elsewhere.
  • Used unsigned constant in shared-module/displayio/TileGrid.c to fix gcc warning.
  • Updated frozen modules.

This new version of bleio requires an updated version of Adafruit_CircuitPython_BLE (adafruit_ble) library. Changes are in adafruit/Adafruit_CircuitPython_BLE#15.

dhalbert added 28 commits May 17, 2019 15:47
@dhalbert
WIP
ee81197
@dhalbert
Merge remote-tracking branch 'adafruit/master' into ble-scanner
b71f6c9
@dhalbert
Scanner working, but not very first time
1639354
@dhalbert
Need to enable ble before scanning
6cec81b
@dhalbert
fix advertisement length check; add Service.secondary attribute
12f1d9d
@dhalbert
1. Remove advertising data construction in C: it's all done in Python…
63ac379 
… now

2. Add scan response capability to advertising.
@dhalbert
Replace Broadcaster with enhanced Peripheral
613e12f
@dhalbert
Make advertising data buffers long-lived
1905d90
@dhalbert
WIP
6fed24e
@dhalbert
merge from upstream; WIP redo Address; no more AddressType
bed6d43
@dhalbert
Merge remote-tracking branch 'adafruit/master' into ble-scanner
cfa8b4b
@dhalbert
Handle None for BLE name; fix ScanEntry bug; compile issue
1356819
@dhalbert
Don't operate directly on bleio objects in shared-bindings: use commo…
35b9191 
…n_hal

routines instead. Changes made but not yet tested.
@dhalbert
Update copyrights; get ready for Central
a1b5d80
@dhalbert
WIP: backup only; not compiled
24ac1fd
@dhalbert
WIP: Central compiles; now will test
4881e1f
@dhalbert
getting Scanner to work
140904e
@dhalbert
Central is connecting; characteristics can be read and written
6ea01ea
@dhalbert
WIP: CharacteristicBuffer for Central; not working: need to set remot…
bf8a35b 
…e Characteristic Service
@dhalbert
WIP: Need descriptors for Central CCCD discovery; not done yet
09ddff8
@dhalbert
UARTClient now works both directions
118b26b
@dhalbert
make translate
ddd4d61
@dhalbert
merge from master
6a00178
@dhalbert
translation merges
d8a4f71
@dhalbert
Fix sphinx warnings.
514d414
@dhalbert
Merge remote-tracking branch 'adafruit/master' into ble-scanner
1cf8a3e
@dhalbert
merge from master and make translate
12b98be
@dhalbert
update frozen libraries
cb99546
@dhalbert dhalbert requested review from tannewt and jerryneedell July 11, 2019 23:16
@dhalbert dhalbert mentioned this pull request Jul 11, 2019
Merged
tannewt
tannewt requested changes Jul 16, 2019
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super exciting! I like the simplifications you've done and the move to common hal. A number of small questions I have for now. I'm excited for the world where a scan reveals all of the circuitpython powered devices I have going around me.

@dhalbert dhalbert added this to the 5.x milestone Jul 17, 2019
tannewt
tannewt approved these changes Jul 18, 2019
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you for your hard work on this.

@tannewt tannewt merged commit 74be29c into adafruit:master Jul 18, 2019
@dhalbert dhalbert deleted the ble-scanner branch July 19, 2019 14:29
This was referenced Jul 31, 2019
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt approved these changes

@jerryneedell jerryneedell Awaiting requested review from jerryneedell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dhalbert @tannewt