Skip to content

Add reverse_rows to speedy bitmaptools.readinto function #4428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 18, 2021

Conversation

kmatch98
Copy link

The recent addition of the bitmaptools.readinto function helps speed loading of bitmap files. This provides an additional input variable reverse_rows to flip the row order to accommodate the format of some bitmap files.

This is required for speedups to the Adafruit_CircuitPython_Imageloadlibrary: adafruit/Adafruit_CircuitPython_ImageLoad#45

(Note: There were some doc string changes that appeared due to my manual merging. I tried to match the formatting with the right spacing, and I verified locally that this PR's files build ok in the docs.)

@tannewt tannewt requested a review from jepler March 18, 2021 01:13
Copy link

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't test, looks fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants