Skip to content

Fix ItsyBitsy RP2040 board definition #4687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2021
Merged

Conversation

kattni
Copy link

@kattni kattni commented Apr 29, 2021

The LED pin was incorrect.

@kattni kattni requested a review from jepler April 29, 2021 16:42
jepler
jepler previously approved these changes Apr 29, 2021
Copy link

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it passes CI, merge it!

@kattni
Copy link
Author

kattni commented Apr 29, 2021

Please wait to merge this. There's another potentially incorrect pin. Troubleshooting now.

@jepler jepler self-requested a review April 29, 2021 16:55
@kattni
Copy link
Author

kattni commented Apr 29, 2021

This fix has been verified against the schematic. I also built CircuitPython and tested all three pin changes. LED, BUTTON and D5 now all work properly with this fix.

Copy link
Collaborator

@hierophect hierophect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending CI

@hierophect hierophect changed the title Fixing board definition. Fix ItsyBitsy RP2040 board definition Apr 29, 2021
@hierophect hierophect added the rp2040 Raspberry Pi RP2040 label Apr 29, 2021
@kattni kattni merged commit ad805f5 into adafruit:main Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rp2040 Raspberry Pi RP2040
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants