Skip to content

Turn off duplicate code checking in examples #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Feb 25, 2021

It's common for us to duplicate code across examples to make them standalone.

It's common for us to duplicate code across examples to make them standalone.
@tannewt
Copy link
Member Author

tannewt commented Feb 25, 2021

@kattni @makermelissa @hugodahl What do you think about this? I've seen two repos failing with this check on examples. Library code itself shouldn't duplicate code, although we may want to raise the bar for it a bit.

@makermelissa
Copy link
Collaborator

makermelissa commented Feb 25, 2021

I think this is the correct way to fix it. At least until we have something more dynamic in place.

@hugodahl
Copy link
Contributor

The changes I've made in #109 should address this issue, since it checks each file in the /examples directory individually. I also believe that @kattni had tried using that duplicate-code disable flag, to no avail, though I may have misunderstood that.

@tannewt
Copy link
Member Author

tannewt commented Feb 25, 2021

The changes I've made in #109 should address this issue, since it checks each file in the /examples directory individually. I also believe that @kattni had tried using that duplicate-code disable flag, to no avail, though I may have misunderstood that.

Ah! That will work. Do you know what the roll out plan is for this config?

@hugodahl
Copy link
Contributor

Unfortunately, I don't know what the rollout plan is. @dherrada may know, but that's about all I can provide.

@evaherrada
Copy link
Collaborator

@tannewt @hugodahl I'm planning on running the patch in the next hour or so.

@hugodahl
Copy link
Contributor

Should this PR be closed since there's #109 for it, or do we want to keep it around for a bit in case we need to refine the process some?

@kattni
Copy link
Contributor

kattni commented Mar 10, 2021

This would not have worked anyway, duplicate code cannot be disabled in the way other directives can. Closing this PR as we resolved it in another PR.

@kattni kattni closed this Mar 10, 2021
@askpatrickw askpatrickw deleted the tannewt-patch-9 branch September 14, 2021 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants