Skip to content

Extratreev2 #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: extratreenan
Choose a base branch
from
Open

Extratreev2 #3

wants to merge 3 commits into from

Conversation

adam2392
Copy link
Owner

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Any other comments?

@adam2392
Merge branch 'main' into extratreenan
6b9e387
@adam2392
Adding update
1c2b807 
Signed-off-by: Adam Li <adam2392@gmail.com>
@adam2392
Trying a separate variation
2ca08b5 
Signed-off-by: Adam Li <adam2392@gmail.com>
@github-actions GitHub Actions
Copy link

❌ Linting issues

This PR is introducing linting issues. Here's a summary of the issues. Note that you can avoid having linting issues by enabling pre-commit hooks. Instructions to enable them can be found here.

You can see the details of the linting issues under the lint job here

black

black detected issues. Please run black . locally and push the changes. Here you can see the detected issues. Note that running black might also fix some of the issues which might be detected by ruff. Note that the installed black version is black=23.3.0.


--- /home/runner/work/scikit-learn/scikit-learn/sklearn/tree/tests/test_tree.py	2024-01-25 17:12:45.290400 +0000
+++ /home/runner/work/scikit-learn/scikit-learn/sklearn/tree/tests/test_tree.py	2024-01-25 17:13:11.874627 +0000
@@ -2548,14 +2548,38 @@
 
 
 @pytest.mark.parametrize(
     "make_data, Tree, resilience_score, dummy_model, p",
     [
-        (datasets.make_regression, DecisionTreeRegressor, 0.9, DummyRegressor, [0.9, 0.1]),
-        (datasets.make_classification, DecisionTreeClassifier, 0.9, DummyClassifier, [0.9, 0.1]),
-        (datasets.make_regression, ExtraTreeRegressor, 0.5, DummyRegressor, [0.95, 0.05]),
-        (datasets.make_classification, ExtraTreeClassifier, 0.6, DummyClassifier, [0.95, 0.05]),
+        (
+            datasets.make_regression,
+            DecisionTreeRegressor,
+            0.9,
+            DummyRegressor,
+            [0.9, 0.1],
+        ),
+        (
+            datasets.make_classification,
+            DecisionTreeClassifier,
+            0.9,
+            DummyClassifier,
+            [0.9, 0.1],
+        ),
+        (
+            datasets.make_regression,
+            ExtraTreeRegressor,
+            0.5,
+            DummyRegressor,
+            [0.95, 0.05],
+        ),
+        (
+            datasets.make_classification,
+            ExtraTreeClassifier,
+            0.6,
+            DummyClassifier,
+            [0.95, 0.05],
+        ),
     ],
 )
 @pytest.mark.parametrize("sample_weight_train", [None, "ones"])
 def test_missing_values_is_resilience(
     make_data, Tree, resilience_score, dummy_model, p, sample_weight_train
would reformat /home/runner/work/scikit-learn/scikit-learn/sklearn/tree/tests/test_tree.py

Oh no! 💥 💔 💥
1 file would be reformatted, 904 files would be left unchanged.

ruff

ruff detected issues. Please run ruff --fix --show-source . locally, fix the remaining issues, and push the changes. Here you can see the detected issues. Note that the installed ruff version is ruff=0.1.14.


sklearn/tree/tests/test_tree.py:2553:89: E501 Line too long (91 > 88)
     |
2551 |     "make_data, Tree, resilience_score, dummy_model, p",
2552 |     [
2553 |         (datasets.make_regression, DecisionTreeRegressor, 0.9, DummyRegressor, [0.9, 0.1]),
     |                                                                                         ^^^ E501
2554 |         (datasets.make_classification, DecisionTreeClassifier, 0.9, DummyClassifier, [0.9, 0.1]),
2555 |         (datasets.make_regression, ExtraTreeRegressor, 0.5, DummyRegressor, [0.95, 0.05]),
     |

sklearn/tree/tests/test_tree.py:2554:89: E501 Line too long (97 > 88)
     |
2552 |     [
2553 |         (datasets.make_regression, DecisionTreeRegressor, 0.9, DummyRegressor, [0.9, 0.1]),
2554 |         (datasets.make_classification, DecisionTreeClassifier, 0.9, DummyClassifier, [0.9, 0.1]),
     |                                                                                         ^^^^^^^^^ E501
2555 |         (datasets.make_regression, ExtraTreeRegressor, 0.5, DummyRegressor, [0.95, 0.05]),
2556 |         (datasets.make_classification, ExtraTreeClassifier, 0.6, DummyClassifier, [0.95, 0.05]),
     |

sklearn/tree/tests/test_tree.py:2555:89: E501 Line too long (90 > 88)
     |
2553 |         (datasets.make_regression, DecisionTreeRegressor, 0.9, DummyRegressor, [0.9, 0.1]),
2554 |         (datasets.make_classification, DecisionTreeClassifier, 0.9, DummyClassifier, [0.9, 0.1]),
2555 |         (datasets.make_regression, ExtraTreeRegressor, 0.5, DummyRegressor, [0.95, 0.05]),
     |                                                                                         ^^ E501
2556 |         (datasets.make_classification, ExtraTreeClassifier, 0.6, DummyClassifier, [0.95, 0.05]),
2557 |     ],
     |

sklearn/tree/tests/test_tree.py:2556:89: E501 Line too long (96 > 88)
     |
2554 |         (datasets.make_classification, DecisionTreeClassifier, 0.9, DummyClassifier, [0.9, 0.1]),
2555 |         (datasets.make_regression, ExtraTreeRegressor, 0.5, DummyRegressor, [0.95, 0.05]),
2556 |         (datasets.make_classification, ExtraTreeClassifier, 0.6, DummyClassifier, [0.95, 0.05]),
     |                                                                                         ^^^^^^^^ E501
2557 |     ],
2558 | )
     |

Found 4 errors.

cython-lint

cython-lint detected issues. Please fix them locally and push the changes. Here you can see the detected issues. Note that the installed cython-lint version is cython-lint=0.16.0.


/home/runner/work/scikit-learn/scikit-learn/sklearn/tree/_splitter.pyx:856:1: W293 blank line contains whitespace

Generated for commit: 2ca08b5. Link to the linter CI: here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adam2392