Fix breakage in AlterFunction().

tglsfdc · tglsfdc · commit 08a9e7a8c791 · 2022-04-19T23:03:59.000-04:00
An ALTER FUNCTION command that tried to update both the function's proparallel property and its proconfig list failed to do the former, because it stored the new proparallel value into a tuple that was no longer the interesting one. Carelessness in 7aea8e4. (I did not bother with a regression test, because the only likely future breakage would be for someone to ignore the comment I added and add some other field update after the heap_modify_tuple step. A test using existing function properties could not catch that.) Per report from Bryn Llewellyn. Back-patch to all supported branches. Discussion: https://postgr.es/m/8AC9A37F-99BD-446F-A2F7-B89AD0022774@yugabyte.com
diff --git a/src/backend/commands/functioncmds.c b/src/backend/commands/functioncmds.c
@@ -1489,6 +1489,8 @@ AlterFunction(ParseState *pstate, AlterFunctionStmt *stmt)
 
 		procForm->prosupport = newsupport;
 	}
+	if (parallel_item)
+		procForm->proparallel = interpret_func_parallel(parallel_item);
 	if (set_items)
 	{
 		Datum		datum;
@@ -1523,8 +1525,7 @@ AlterFunction(ParseState *pstate, AlterFunctionStmt *stmt)
 		tup = heap_modify_tuple(tup, RelationGetDescr(rel),
 								repl_val, repl_null, repl_repl);
 	}
-	if (parallel_item)
-		procForm->proparallel = interpret_func_parallel(parallel_item);
+	/* DO NOT put more touches of procForm below here; it's now dangling. */
 
 	/* Do the update */
 	CatalogTupleUpdate(rel, &tup->t_self, tup);

Original file line number	Diff line number	Diff line change
`@@ -1489,6 +1489,8 @@ AlterFunction(ParseState pstate, AlterFunctionStmt stmt)`
`1489`	`1489`
`1490`	`1490`	`procForm->prosupport = newsupport;`
`1491`	`1491`	`}`
	`1492`	`+ if (parallel_item)`
	`1493`	`+ procForm->proparallel = interpret_func_parallel(parallel_item);`
`1492`	`1494`	`if (set_items)`
`1493`	`1495`	`{`
`1494`	`1496`	`Datum datum;`
`@@ -1523,8 +1525,7 @@ AlterFunction(ParseState pstate, AlterFunctionStmt stmt)`
`1523`	`1525`	`tup = heap_modify_tuple(tup, RelationGetDescr(rel),`
`1524`	`1526`	`repl_val, repl_null, repl_repl);`
`1525`	`1527`	`}`
`1526`		`- if (parallel_item)`
`1527`		`- procForm->proparallel = interpret_func_parallel(parallel_item);`
	`1528`	`+ /* DO NOT put more touches of procForm below here; it's now dangling. */`
`1528`	`1529`
`1529`	`1530`	`/* Do the update */`
`1530`	`1531`	`CatalogTupleUpdate(rel, &tup->t_self, tup);`