Fix missing fsync of SLRU directories.

macdice · macdice · commit 23d8b3577d0c · 2020-09-24T10:36:27.000+12:00
Harmonize behavior by moving reponsibility for fsyncing directories down into slru.c. In 10 and later, only the multixact directories were missed (see commit 1b02be2), and in older branches all SLRUs were missed. Back-patch to all supported releases. Reviewed-by: Andres Freund <andres@anarazel.de> Reviewed-by: Michael Paquier <michael@paquier.xyz> Discussion: https://postgr.es/m/CA%2BhUKGLtsTUOScnNoSMZ-2ZLv%2BwGh01J6kAo_DM8mTRq1sKdSQ%40mail.gmail.com
diff --git a/src/backend/access/transam/slru.c b/src/backend/access/transam/slru.c
@@ -1133,6 +1133,10 @@ SimpleLruFlush(SlruCtl ctl, bool allow_redirtied)
 	}
 	if (!ok)
 		SlruReportIOError(ctl, pageno, InvalidTransactionId);
+
+	/* Ensure that directory entries for new files are on disk. */
+	if (ctl->do_fsync)
+		fsync_fname(ctl->Dir, true);
 }
 
 /*

Original file line number	Diff line number	Diff line change
`@@ -1133,6 +1133,10 @@ SimpleLruFlush(SlruCtl ctl, bool allow_redirtied)`
`1133`	`1133`	`}`
`1134`	`1134`	`if (!ok)`
`1135`	`1135`	`SlruReportIOError(ctl, pageno, InvalidTransactionId);`
	`1136`	`+`
	`1137`	`+ /* Ensure that directory entries for new files are on disk. */`
	`1138`	`+ if (ctl->do_fsync)`
	`1139`	`+ fsync_fname(ctl->Dir, true);`
`1136`	`1140`	`}`
`1137`	`1141`
`1138`	`1142`	`/*`