Avoid O(N^2) behavior when enlarging SPI tuple table in spi_printtup().

tglsfdc · tglsfdc · commit 7c57449fc585 · 2015-08-21T20:32:41.000-04:00
For no obvious reason, spi_printtup() was coded to enlarge the tuple
pointer table by just 256 slots at a time, rather than doubling the size at
each reallocation, as is our usual habit.  For very large SPI results, this
makes for O(N^2) time spent in repalloc(), which of course soon comes to
dominate the runtime.  Use the standard doubling approach instead.

This is a longstanding performance bug, so back-patch to all active
branches.

Neil Conway
diff --git a/src/backend/executor/spi.c b/src/backend/executor/spi.c
@@ -1622,7 +1622,8 @@ spi_printtup(TupleTableSlot *slot, DestReceiver *self)
 
 	if (tuptable->free == 0)
 	{
-		tuptable->free = 256;
+		/* Double the size of the pointer array */
+		tuptable->free = tuptable->alloced;
 		tuptable->alloced += tuptable->free;
 		tuptable->vals = (HeapTuple *) repalloc(tuptable->vals,
 									  tuptable->alloced * sizeof(HeapTuple));

Original file line number	Diff line number	Diff line change
`@@ -1622,7 +1622,8 @@ spi_printtup(TupleTableSlot slot, DestReceiver self)`
`1622`	`1622`
`1623`	`1623`	`if (tuptable->free == 0)`
`1624`	`1624`	`{`
`1625`		`- tuptable->free = 256;`
	`1625`	`+ /* Double the size of the pointer array */`
	`1626`	`+ tuptable->free = tuptable->alloced;`
`1626`	`1627`	`tuptable->alloced += tuptable->free;`
`1627`	`1628`	`tuptable->vals = (HeapTuple *) repalloc(tuptable->vals,`
`1628`	`1629`	`tuptable->alloced * sizeof(HeapTuple));`