Remove JsonPathSpec typedef

petere · petere · commit dc2be6ed47e5 · 2022-05-04T17:36:31.000+02:00
It doesn't seem very useful, and it's a bit in the way of the planned node support automation. Discussion: https://www.postgresql.org/message-id/202204191140.3wsbevfhqmu3@alvherre.pgsql
diff --git a/src/backend/parser/parse_jsontable.c b/src/backend/parser/parse_jsontable.c
@@ -73,7 +73,7 @@ transformJsonTableColumn(JsonTableColumn *jtc, Node *contextItemExpr,
 	JsonFuncExpr *jfexpr = makeNode(JsonFuncExpr);
 	JsonCommon *common = makeNode(JsonCommon);
 	JsonOutput *output = makeNode(JsonOutput);
-	JsonPathSpec pathspec;
+	char	   *pathspec;
 	JsonFormat *default_format;
 
 	jfexpr->op =
diff --git a/src/include/nodes/parsenodes.h b/src/include/nodes/parsenodes.h
@@ -1619,12 +1619,6 @@ typedef enum JsonTableColumnType
 	JTC_NESTED,
 } JsonTableColumnType;
 
-/*
- * JsonPathSpec -
- *		representation of JSON path constant
- */
-typedef char *JsonPathSpec;
-
 /*
  * JsonOutput -
  *		representation of JSON output clause (RETURNING type [FORMAT format])
@@ -1688,7 +1682,7 @@ typedef struct JsonTableColumn
 	JsonTableColumnType coltype;	/* column type */
 	char	   *name;				/* column name */
 	TypeName   *typeName;			/* column type name */
-	JsonPathSpec pathspec;			/* path specification, if any */
+	char	   *pathspec;			/* path specification, if any */
 	char	   *pathname;			/* path name, if any */
 	JsonFormat *format;				/* JSON format clause, if specified */
 	JsonWrapper	wrapper;			/* WRAPPER behavior for formatted columns */
