Skip to content

Commit e46cd42

Browse files
committed
Update reference to sampling algorithm in analyze.c
Commit 83e176e moved row sampling functions from analyze.c to utils/misc/sampling.c, but failed to update comment referring to the sampling algorithm from Jeff Vitter's paper. Correct the comment by pointing to utils/misc/sampling.c. Author: Etsuro Fujita Discussion: https://postgr.es/m/CAPmGK154gp%2BQd%3DcorQOv%2BPmbyVyZBjp_%2Bhb766UJeD1e_ie6XQ%40mail.gmail.com
1 parent 05b2758 commit e46cd42

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

src/backend/commands/analyze.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1252,13 +1252,13 @@ acquire_sample_rows(Relation onerel, int elevel,
12521252
* The first targrows sample rows are simply copied into the
12531253
* reservoir. Then we start replacing tuples in the sample
12541254
* until we reach the end of the relation. This algorithm is
1255-
* from Jeff Vitter's paper (see full citation below). It
1256-
* works by repeatedly computing the number of tuples to skip
1257-
* before selecting a tuple, which replaces a randomly chosen
1258-
* element of the reservoir (current set of tuples). At all
1259-
* times the reservoir is a true random sample of the tuples
1260-
* we've passed over so far, so when we fall off the end of
1261-
* the relation we're done.
1255+
* from Jeff Vitter's paper (see full citation in
1256+
* utils/misc/sampling.c). It works by repeatedly computing
1257+
* the number of tuples to skip before selecting a tuple,
1258+
* which replaces a randomly chosen element of the reservoir
1259+
* (current set of tuples). At all times the reservoir is a
1260+
* true random sample of the tuples we've passed over so far,
1261+
* so when we fall off the end of the relation we're done.
12621262
*/
12631263
if (numrows < targrows)
12641264
rows[numrows++] = heap_copytuple(&targtuple);

0 commit comments

Comments
 (0)