Improve message about failed transaction log archiving

petere · petere · commit f5d576c6d278 · 2013-04-26T22:43:54.000-04:00
The old phrasing appeared to imply that the failure was terminal.
Improve that by indicating that archiving will be tried again later.
diff --git a/src/backend/postmaster/pgarch.c b/src/backend/postmaster/pgarch.c
@@ -503,7 +503,7 @@ pgarch_ArchiverCopyLoop(void)
 				if (++failures >= NUM_ARCHIVE_RETRIES)
 				{
 					ereport(WARNING,
-							(errmsg("transaction log file \"%s\" could not be archived: too many failures",
+							(errmsg("archiving transaction log file \"%s\" failed too many times, will try again later",
 									xlog)));
 					return;		/* give up archiving for now */
 				}

Original file line number	Diff line number	Diff line change
`@@ -503,7 +503,7 @@ pgarch_ArchiverCopyLoop(void)`
`503`	`503`	`if (++failures >= NUM_ARCHIVE_RETRIES)`
`504`	`504`	`{`
`505`	`505`	`ereport(WARNING,`
`506`		`- (errmsg("transaction log file \"%s\" could not be archived: too many failures",`
	`506`	`+ (errmsg("archiving transaction log file \"%s\" failed too many times, will try again later",`
`507`	`507`	`xlog)));`
`508`	`508`	`return; /* give up archiving for now */`
`509`	`509`	`}`