use encodeURI instead of string replace

francoisp · brianc · commit 77daa06df99d · 2013-01-29T19:54:25.000-06:00
diff --git a/lib/connection-parameters.js b/lib/connection-parameters.js
@@ -17,7 +17,7 @@ var parse = function(str) {
     return { host: str };
   }
   // url parse expects spaces encoded as %20
-  str = str.replace(' ', '%20');
+  str = encodeURI(str);
   var result = url.parse(str);
   var config = {};
   config.host = result.hostname;

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ var parse = function(str) {`
`17`	`17`	`return { host: str };`
`18`	`18`	`}`
`19`	`19`	`// url parse expects spaces encoded as %20`
`20`		`- str = str.replace(' ', '%20');`
	`20`	`+ str = encodeURI(str);`
`21`	`21`	`var result = url.parse(str);`
`22`	`22`	`var config = {};`
`23`	`23`	`config.host = result.hostname;`