Bug in save best solutions #25
Assignees
Labels
bug
Something isn't working
Comments
|
Thanks. The bug is fixed by creating a copy of the best solution. This prevents a solution saved in the The next line: best_solution = self.population[best_match_idx, :]is replaced by this line: best_solution = self.population[best_match_idx, :].copy() |
ahmedfgad
added a commit
that referenced
this issue
Jan 15, 2021
A bug fix when save_best_solutions=True. Refer to this issue for more information: #25
|
PyGAD 2.10.2 is released which addresses this issue. Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
If
save_best_solutions = True, thebest_solutionslist is overwritten after each generation when a new population is being generated. A bug appears on line number 748. Solutions stored inbest_solutionsare probably just shallow copies, i.e., pointers topopulation.What the bug looks like
best_solutions = []best_solutions = [[9, 10, 5, 9, 9]]# after append on the line 728, it holds first best solution foundbest_solutions = [[6, 9, 6, 9, 6]]# after the line 748, original value has been changed (changed after every single generation)The text was updated successfully, but these errors were encountered: