Upgrade to llhttp 9.2.1 #8292

Dreamsorcerer · 2024-04-04T17:24:13Z

for more information, see https://pre-commit.ci

codecov · 2024-04-04T22:26:24Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.57%. Comparing base (28f1fd8) to head (e545b19).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #8292      +/-   ##
==========================================
+ Coverage   97.49%   97.57%   +0.07%     
==========================================
  Files         107      107              
  Lines       32987    33085      +98     
  Branches     3853     3868      +15     
==========================================
+ Hits        32162    32282     +120     
+ Misses        606      587      -19     
+ Partials      219      216       -3

Flag	Coverage Δ
CI-GHA	`97.48% <100.00%> (+0.06%)`	⬆️
OS-Linux	`97.15% <100.00%> (+0.06%)`	⬆️
OS-Windows	`95.65% <100.00%> (-0.07%)`	⬇️
OS-macOS	`96.86% <100.00%> (+<0.01%)`	⬆️
Py-3.10.11	`95.50% <100.00%> (-0.07%)`	⬇️
Py-3.10.14	`96.95% <100.00%> (+<0.01%)`	⬆️
Py-3.11.8	`97.15% <100.00%> (+<0.01%)`	⬆️
Py-3.12.2	`97.27% <100.00%> (+<0.01%)`	⬆️
Py-3.8.10	`95.42% <100.00%> (-0.12%)`	⬇️
Py-3.8.18	`96.80% <100.00%> (-0.09%)`	⬇️
Py-3.9.13	`95.47% <100.00%> (-0.07%)`	⬇️
Py-3.9.18	`?`
Py-3.9.19	`96.93% <100.00%> (+0.03%)`	⬆️
Py-pypy7.3.15	`96.46% <100.00%> (?)`
VM-macos	`96.86% <100.00%> (+<0.01%)`	⬆️
VM-ubuntu	`97.15% <100.00%> (+0.06%)`	⬆️
VM-windows	`95.65% <100.00%> (-0.07%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bdraco · 2024-04-04T22:30:30Z

I'll give it a test now

Dreamsorcerer · 2024-04-04T22:35:36Z

I think the only change is disabling obsolete line folding by default.

bdraco · 2024-04-04T22:37:11Z

It looks quite safe. Not expecting any issues (but would rather not found out later)

bdraco

Tested on production. Everything seems ok.

Dreamsorcerer · 2024-04-05T00:09:03Z

tests/test_http_parser.py

-    assert msg.method == "GET"
-    assert msg.path == "/test"
+    assert msg.code == 200
+    assert msg.reason == "Ok"
    assert msg.version == (1, 1)
    assert msg.headers == CIMultiDict({"data": "test " + value.decode()})
    assert msg.raw_headers == ((b"data", b"test " + value),)
    assert not msg.should_close


It would appear the C parser is setting this to True while the Python parser is setting it to False. I'm not sure of the significance of that... (This was probably already like that before this release, as I've switched the test to use the response parser).

I think this is a bug nodejs/llhttp#354
Will just comment out the check to get this merged.

patchback · 2024-04-05T18:23:53Z

Backport to 3.9: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 4d72dca on top of patchback/backports/3.9/4d72dca6869072fb073621f8b752225e216a92d9/pr-8292

Backporting merged PR #8292 into master

Ensure you have a local repo clone of your fork. Unless you cloned it
from the upstream, this would be your origin remote.
Make sure you have an upstream repo added as a remote too. In these
instructions you'll refer to it by the name upstream. If you don't
have it, here's how you can add it:
```
$ git remote add upstream https://github.com/aio-libs/aiohttp.git
```

Ensure you have the latest copy of upstream and prepare a branch
that will hold the backported code:

$ git fetch upstream
$ git checkout -b patchback/backports/3.9/4d72dca6869072fb073621f8b752225e216a92d9/pr-8292 upstream/3.9

Now, cherry-pick PR Upgrade to llhttp 9.2.1 #8292 contents into that branch:
```
$ git cherry-pick -x 4d72dca6869072fb073621f8b752225e216a92d9
```
If it'll yell at you with something like fatal: Commit 4d72dca6869072fb073621f8b752225e216a92d9 is a merge but no -m option was given., add -m 1 as follows instead:
```
$ git cherry-pick -m1 -x 4d72dca6869072fb073621f8b752225e216a92d9
```
At this point, you'll probably encounter some merge conflicts. You must
resolve them in to preserve the patch from PR Upgrade to llhttp 9.2.1 #8292 as close to the
original as possible.

Push this branch to your fork on GitHub:

$ git push origin patchback/backports/3.9/4d72dca6869072fb073621f8b752225e216a92d9/pr-8292

Create a PR, ensure that the CI is green. If it's not — update it so that
the tests and any other checks pass. This is it!
Now relax and wait for the maintainers to process your pull request
when they have some cycles to do reviews. Don't worry — they'll tell you if
any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback · 2024-04-05T18:23:58Z

Backport to 3.10: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 4d72dca on top of patchback/backports/3.10/4d72dca6869072fb073621f8b752225e216a92d9/pr-8292

Backporting merged PR #8292 into master

Ensure you have a local repo clone of your fork. Unless you cloned it
from the upstream, this would be your origin remote.
Make sure you have an upstream repo added as a remote too. In these
instructions you'll refer to it by the name upstream. If you don't
have it, here's how you can add it:
```
$ git remote add upstream https://github.com/aio-libs/aiohttp.git
```

Ensure you have the latest copy of upstream and prepare a branch
that will hold the backported code:

$ git fetch upstream
$ git checkout -b patchback/backports/3.10/4d72dca6869072fb073621f8b752225e216a92d9/pr-8292 upstream/3.10

Now, cherry-pick PR Upgrade to llhttp 9.2.1 #8292 contents into that branch:
```
$ git cherry-pick -x 4d72dca6869072fb073621f8b752225e216a92d9
```
If it'll yell at you with something like fatal: Commit 4d72dca6869072fb073621f8b752225e216a92d9 is a merge but no -m option was given., add -m 1 as follows instead:
```
$ git cherry-pick -m1 -x 4d72dca6869072fb073621f8b752225e216a92d9
```
At this point, you'll probably encounter some merge conflicts. You must
resolve them in to preserve the patch from PR Upgrade to llhttp 9.2.1 #8292 as close to the
original as possible.

Push this branch to your fork on GitHub:

$ git push origin patchback/backports/3.10/4d72dca6869072fb073621f8b752225e216a92d9/pr-8292

Create a PR, ensure that the CI is green. If it's not — update it so that
the tests and any other checks pass. This is it!
Now relax and wait for the maintainers to process your pull request
when they have some cycles to do reviews. Don't worry — they'll tell you if
any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Fixes #8291. (cherry picked from commit 4d72dca)

Fixes #8291. (cherry picked from commit 4d72dca) (cherry picked from commit d15f07c)

) **This is a backport of PR #8297 as merged into 3.10 (d15f07c).** Fixes #8291. (cherry picked from commit 4d72dca) Co-authored-by: Sam Bull <git@sambull.org>

Upgrade to llhttp 9.2.1

d9b90ea

Dreamsorcerer added backport-3.9 labels Apr 4, 2024

Dreamsorcerer requested review from webknjaz and asvetlov as code owners April 4, 2024 17:24

Create 8292.feature.rst

f5c2836

psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Apr 4, 2024

Dreamsorcerer and others added 4 commits April 4, 2024 23:08

Update test_http_parser.py

17beca1

Update http_parser.py

2011b8e

[pre-commit.ci] auto fixes from pre-commit.com hooks

c1d3b96

for more information, see https://pre-commit.ci

Update 8292.feature.rst

e6adafe

bdraco approved these changes Apr 4, 2024

View reviewed changes

Dreamsorcerer added 2 commits April 5, 2024 00:33

Update 8292.feature.rst

be746a8

Update test_http_parser.py

c47e018

musicinmybrain mentioned this pull request Apr 4, 2024

Please update llhttp to 9.2.1 #8291

Closed

1 task

Dreamsorcerer added 2 commits April 5, 2024 00:48

Update test_http_parser.py

ae67e34

Update test_http_parser.py

79ed09f

Dreamsorcerer commented Apr 5, 2024

View reviewed changes

Update test_http_parser.py

e545b19

Dreamsorcerer merged commit 4d72dca into master Apr 5, 2024
36 of 37 checks passed

Dreamsorcerer deleted the llhttp branch April 5, 2024 18:23

Dreamsorcerer added a commit that referenced this pull request Apr 5, 2024

Upgrade to llhttp 9.2.1 (#8292)

bf71e49

Fixes #8291. (cherry picked from commit 4d72dca)

Dreamsorcerer added a commit that referenced this pull request Apr 5, 2024

Upgrade to llhttp 9.2.1 (#8292) (#8297)

d15f07c

Fixes #8291. (cherry picked from commit 4d72dca)

patchback bot pushed a commit that referenced this pull request Apr 5, 2024

Upgrade to llhttp 9.2.1 (#8292) (#8297)

bf0ff35

Fixes #8291. (cherry picked from commit 4d72dca) (cherry picked from commit d15f07c)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to llhttp 9.2.1 #8292

Upgrade to llhttp 9.2.1 #8292

Dreamsorcerer commented Apr 4, 2024

codecov bot commented Apr 4, 2024 •

edited

Loading

bdraco commented Apr 4, 2024

Dreamsorcerer commented Apr 4, 2024

bdraco commented Apr 4, 2024

bdraco left a comment

Dreamsorcerer Apr 5, 2024

Dreamsorcerer Apr 5, 2024

patchback bot commented Apr 5, 2024 •

edited

Loading

patchback bot commented Apr 5, 2024 •

edited

Loading

Upgrade to llhttp 9.2.1 #8292

Upgrade to llhttp 9.2.1 #8292

Conversation

Dreamsorcerer commented Apr 4, 2024

codecov bot commented Apr 4, 2024 • edited Loading

Codecov Report

bdraco commented Apr 4, 2024

Dreamsorcerer commented Apr 4, 2024

bdraco commented Apr 4, 2024

bdraco left a comment

Choose a reason for hiding this comment

Dreamsorcerer Apr 5, 2024

Choose a reason for hiding this comment

Dreamsorcerer Apr 5, 2024

Choose a reason for hiding this comment

patchback bot commented Apr 5, 2024 • edited Loading

Backport to 3.9: 💔 cherry-picking failed — conflicts found

Backporting merged PR #8292 into master

patchback bot commented Apr 5, 2024 • edited Loading

Backport to 3.10: 💔 cherry-picking failed — conflicts found

Backporting merged PR #8292 into master

codecov bot commented Apr 4, 2024 •

edited

Loading

patchback bot commented Apr 5, 2024 •

edited

Loading

patchback bot commented Apr 5, 2024 •

edited

Loading