The return value of __virtual__ should never be None

s0undt3ch · s0undt3ch · commit d301d8c25e49 · 2014-12-13T09:38:15.000Z
diff --git a/salt/modules/sysrc.py b/salt/modules/sysrc.py
@@ -2,12 +2,17 @@
 '''
 sysrc module for FreeBSD
 '''
+
+# Import Python libs
 from __future__ import absolute_import
 
+# Import Salt libs
 import salt.utils
 from salt.exceptions import CommandExecutionError
 
 
+__virtualname__ = 'sysrc'
+
 __func_alias__ = {
     'set_': 'set'
 }
@@ -17,7 +22,9 @@ def __virtual__():
     '''
     Only runs if sysrc exists
     '''
-    return salt.utils.which_bin('sysrc')
+    if salt.utils.which_bin('sysrc') is not None:
+        return True
+    return False
 
 
 def get(**kwargs):
