Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: AugustKarlstedt/rules_python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: alexrudy/rules_python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
  • 8 commits
  • 619 files changed
  • 2 contributors

Commits on May 25, 2023

  1. fix: respect kind mapping (bazel-contrib#1158)

    When using the kind `gazelle:map_kind` directive, `gazelle` will
    correctly generate the buildfile on the first pass (or if no target of
    that type / name are present).
    
    However, when running gazelle a second time (or if a target of the
    mapped kind with the same name is present), `gazelle` will error out
    saying that it kind create a target of the original kind because a
    target of mapped kind is present and has the same name.
    
    Ex:
    Given the directive `# gazelle:map_kind py_test py_pytest_test
    //src/bazel/rules/python:py_pytest_test.bzl`, `gazelle` will correctly
    generate a `py_pytest_test` target where it would have generated a
    `py_test` target.
    
    But on a second invocation of `gazelle` (and subsequent invocations) it
    will error our with:
    ```
    gazelle: ERROR: failed to generate target "//test/python/common:common_test" of kind "py_test": a target of kind "py_pytest_test" with the same name already exists. Use the '# gazelle:python_test_naming_convention' directive to change the naming convention.
    ```
    OniOni authored and alexrudy committed May 25, 2023
    Configuration menu
    Copy the full SHA
    1eea0a9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    df919d7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    adeec04 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e9648e2 View commit details
    Browse the repository at this point in the history
  5. Re-expose gazelle go module

    alexrudy committed May 25, 2023
    Configuration menu
    Copy the full SHA
    71eb8dd View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    05efdfc View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    b07ae7c View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. Configuration menu
    Copy the full SHA
    cc27e41 View commit details
    Browse the repository at this point in the history
Loading