fix(behave): add proper cleanup

delatrie · delatrie · commit 3a59d6eeace1 · 2025-05-06T01:36:46.000+07:00
diff --git a/allure-behave/src/formatter.py b/allure-behave/src/formatter.py
@@ -12,10 +12,10 @@ def __init__(self, stream_opener, config):
         super(AllureFormatter, self).__init__(stream_opener, config)
 
         self.listener = AllureListener(config)
-        file_logger = AllureFileLogger(self.stream_opener.name)
+        self.file_logger = AllureFileLogger(self.stream_opener.name)
 
         allure_commons.plugin_manager.register(self.listener)
-        allure_commons.plugin_manager.register(file_logger)
+        allure_commons.plugin_manager.register(self.file_logger)
 
         self.testplan = get_testplan()
 
@@ -45,5 +45,14 @@ def result(self, result):
     def eof(self):
         self.listener.stop_feature()
 
+    def close(self):
+        try:
+            super().close()
+        finally:
+            for plugin in [self.file_logger, self.listener]:
+                name = allure_commons.plugin_manager.get_name(plugin)
+                if allure_commons.plugin_manager.has_plugin(name):
+                    allure_commons.plugin_manager.unregister(name=name)
+
     def close_stream(self):
         self.listener.stop_session()
diff --git a/allure-behave/src/hooks.py b/allure-behave/src/hooks.py
@@ -6,6 +6,7 @@
 from behave.configuration import Configuration
 
 HOOKS = [
+    "after_all",
     "before_feature",
     "after_feature",
     "before_scenario",
@@ -42,12 +43,22 @@ def allure_report(result_dir="allure_results"):
 class AllureHooks:
     def __init__(self, result_dir):
         self.listener = AllureListener(Configuration())
+        self.plugins = []
 
         if not hasattr(_storage, 'file_logger'):
-            _storage.file_logger = AllureFileLogger(result_dir)
-            allure_commons.plugin_manager.register(_storage.file_logger)
+            logger = AllureFileLogger(result_dir)
+            _storage.file_logger = logger
+            allure_commons.plugin_manager.register(logger)
+            self.plugins.append(logger)
 
         allure_commons.plugin_manager.register(self.listener)
+        self.plugins.append(self.listener)
+
+    def after_all(self, context):
+        for plugin in self.plugins:
+            name = allure_commons.plugin_manager.get_name(plugin)
+            if allure_commons.plugin_manager.has_plugin(name):
+                allure_commons.plugin_manager.unregister(name=name)
 
     def before_feature(self, context, feature):
         self.listener.start_file()
