fix: improve error handling when posting workspace agent version (coder#5775)

kylecarbs · web-flow · commit 41145a68425b · 2023-01-18T22:03:11.000Z
A customer ran into an unfortunate error here that we miss!
diff --git a/codersdk/workspaceagents.go b/codersdk/workspaceagents.go
@@ -489,15 +489,15 @@ func (c *Client) PostWorkspaceAgentAppHealth(ctx context.Context, req PostWorksp
 }
 
 func (c *Client) PostWorkspaceAgentVersion(ctx context.Context, version string) error {
-	// Phone home and tell the mothership what version we're on.
 	versionReq := PostWorkspaceAgentVersionRequest{Version: version}
 	res, err := c.Request(ctx, http.MethodPost, "/api/v2/workspaceagents/me/version", versionReq)
 	if err != nil {
+		return err
+	}
+	defer res.Body.Close()
+	if res.StatusCode != http.StatusOK {
 		return readBodyAsError(res)
 	}
-	// Discord the response
-	_, _ = io.Copy(io.Discard, res.Body)
-	_ = res.Body.Close()
 	return nil
 }
 

Original file line number	Diff line number	Diff line change
`@@ -489,15 +489,15 @@ func (c *Client) PostWorkspaceAgentAppHealth(ctx context.Context, req PostWorksp`
`489`	`489`	`}`
`490`	`490`
`491`	`491`	`func (c *Client) PostWorkspaceAgentVersion(ctx context.Context, version string) error {`
`492`		`- // Phone home and tell the mothership what version we're on.`
`493`	`492`	`versionReq := PostWorkspaceAgentVersionRequest{Version: version}`
`494`	`493`	`res, err := c.Request(ctx, http.MethodPost, "/api/v2/workspaceagents/me/version", versionReq)`
`495`	`494`	`if err != nil {`
	`495`	`+ return err`
	`496`	`+ }`
	`497`	`+ defer res.Body.Close()`
	`498`	`+ if res.StatusCode != http.StatusOK {`
`496`	`499`	`return readBodyAsError(res)`
`497`	`500`	`}`
`498`		`- // Discord the response`
`499`		`- _, _ = io.Copy(io.Discard, res.Body)`
`500`		`- _ = res.Body.Close()`
`501`	`501`	`return nil`
`502`	`502`	`}`
`503`	`503`