Add periods to end of license warning text. (coder#3933)

spikecurtis · web-flow · commit ac279b348399 · 2022-09-07T17:27:42.000Z
* Add periods to end of license warning text.

Signed-off-by: Spike Curtis &lt;spike@coder.com&gt;

* Fix tests

Signed-off-by: Spike Curtis &lt;spike@coder.com&gt;

Signed-off-by: Spike Curtis &lt;spike@coder.com&gt;
diff --git a/enterprise/coderd/features.go b/enterprise/coderd/features.go
@@ -112,7 +112,7 @@ func (s *featuresService) EntitlementsAPI(rw http.ResponseWriter, r *http.Reques
 		if n > e.activeUsers.limit {
 			resp.Warnings = append(resp.Warnings,
 				fmt.Sprintf(
-					"Your deployment has %d active users but is only licensed for %d",
+					"Your deployment has %d active users but is only licensed for %d.",
 					n, e.activeUsers.limit))
 		}
 	}
@@ -125,7 +125,7 @@ func (s *featuresService) EntitlementsAPI(rw http.ResponseWriter, r *http.Reques
 	}
 	if e.auditLogs.state == gracePeriod && s.enablements.AuditLogs {
 		resp.Warnings = append(resp.Warnings,
-			"Audit logging is enabled but your license for this feature is expired")
+			"Audit logging is enabled but your license for this feature is expired.")
 	}
 
 	httpapi.Write(rw, http.StatusOK, resp)
diff --git a/enterprise/coderd/features_internal_test.go b/enterprise/coderd/features_internal_test.go
@@ -165,9 +165,9 @@ func TestFeaturesService_EntitlementsAPI(t *testing.T) {
 		assert.Nil(t, al.Actual)
 		assert.Len(t, result.Warnings, 2)
 		assert.Contains(t, result.Warnings,
-			"Your deployment has 5 active users but is only licensed for 4")
+			"Your deployment has 5 active users but is only licensed for 4.")
 		assert.Contains(t, result.Warnings,
-			"Audit logging is enabled but your license for this feature is expired")
+			"Audit logging is enabled but your license for this feature is expired.")
 	})
 }
 

Original file line number	Diff line number	Diff line change
`@@ -112,7 +112,7 @@ func (s featuresService) EntitlementsAPI(rw http.ResponseWriter, r http.Reques`
`112`	`112`	`if n > e.activeUsers.limit {`
`113`	`113`	`resp.Warnings = append(resp.Warnings,`
`114`	`114`	`fmt.Sprintf(`
`115`		`- "Your deployment has %d active users but is only licensed for %d",`
	`115`	`+ "Your deployment has %d active users but is only licensed for %d.",`
`116`	`116`	`n, e.activeUsers.limit))`
`117`	`117`	`}`
`118`	`118`	`}`
`@@ -125,7 +125,7 @@ func (s featuresService) EntitlementsAPI(rw http.ResponseWriter, r http.Reques`
`125`	`125`	`}`
`126`	`126`	`if e.auditLogs.state == gracePeriod && s.enablements.AuditLogs {`
`127`	`127`	`resp.Warnings = append(resp.Warnings,`
`128`		`- "Audit logging is enabled but your license for this feature is expired")`
	`128`	`+ "Audit logging is enabled but your license for this feature is expired.")`
`129`	`129`	`}`
`130`	`130`
`131`	`131`	`httpapi.Write(rw, http.StatusOK, resp)`